ai/danielmiessler.fabric
1
0
Fork 0
mirror of https://github.com/danielmiessler/fabric.git synced 2026-09-10 07:36:44 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #2136 from ksylvan/opus-4-8-sampling-params-fix

Browse source 
chore: extend sampling param exclusion to Opus 4.8 models
This commit is contained in:
Kayvan Sylvan 2026-06-02 16:29:14 -07:00 committed by GitHub
parent 7ede03225d 69a79e6efc
commit 8e452510e0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
cmd/generate_changelog/incoming/2136.txt Normal file
View file

@ -0,0 +1,5 @@
### PR [#2136](https://github.com/danielmiessler/Fabric/pull/2136) by [ksylvan](https://github.com/ksylvan): chore: extend sampling param exclusion to Opus 4.8 models
- Extends the sampling parameter exclusion logic to cover Opus 4.8 models, ensuring consistent behavior alongside the existing Opus 4.7 exclusion.
- Adds the `claude-opus-4-8` model prefix to the sampling parameter exclusion check.
- Updates the associated code comment to explicitly reference Opus 4.8 models.

4
internal/plugins/ai/anthropic/anthropic.go
View file

@ -25,9 +25,9 @@ const webSearchToolType = "web_search_20250305"
const sourcesHeader = "## Sources"
func modelDisallowsSamplingParams(model string) bool {
// Anthropic's Opus 4.7 models reject non-default sampling parameters.
// Anthropic's Opus 4.7 and Opus 4.8 models reject non-default sampling parameters.
// Omit these params entirely for safest compatibility.
return strings.HasPrefix(model, "claude-opus-4-7")
return strings.HasPrefix(model, "claude-opus-4-7") || strings.HasPrefix(model, "claude-opus-4-8")
}
func NewClient() (ret *Client) {