refactor: modernize Go code with TypeFor and range loops

- Replace reflect.TypeOf with TypeFor generic syntax
- Convert traditional for loops to range-based iterations
- Simplify reflection usage in CLI flag handling
- Update test loops to use range over integers
- Refactor string processing loops in template plugin

cmd/generate_changelog/incoming/1876.txt

@@ -0,0 +1,7 @@
+### PR [#1876](https://github.com/danielmiessler/Fabric/pull/1876) by [ksylvan](https://github.com/ksylvan): modernize Go code with TypeFor and range loops
+
+- Replace reflect.TypeOf with TypeFor generic syntax for improved type handling
+- Convert traditional for loops to range-based iterations for better code readability
+- Simplify reflection usage in CLI flag handling to reduce complexity
+- Update test loops to use range over integers for cleaner test code
+- Refactor string processing loops in template plugin to use modern Go patterns

internal/cli/flags.go

@@ -115,7 +115,7 @@ func Init() (ret *Flags, err error) {
 
 	// Create mapping from flag names (both short and long) to yaml tag names
 	flagToYamlTag := make(map[string]string)
-	t := reflect.TypeOf(Flags{})
+	t := reflect.TypeFor[Flags]()
 	for i := 0; i < t.NumField(); i++ {
 		field := t.Field(i)
 		yamlTag := field.Tag.Get("yaml")
@@ -224,7 +224,7 @@ func Init() (ret *Flags, err error) {
 }
 
 func parseDebugLevel(args []string) int {
-	for i := 0; i < len(args); i++ {
+	for i := range args {
 		arg := args[i]
 		if arg == "--debug" && i+1 < len(args) {
 			if lvl, err := strconv.Atoi(args[i+1]); err == nil {

internal/cli/help.go

@@ -137,8 +137,7 @@ func (h *TranslatedHelpWriter) getTranslatedDescription(flagName string) string
 
 // getOriginalDescription retrieves the original description from struct tags
 func (h *TranslatedHelpWriter) getOriginalDescription(flagName string) string {
-	flags := &Flags{}
-	flagsType := reflect.TypeOf(flags).Elem()
+	flagsType := reflect.TypeFor[Flags]()
 
 	for i := 0; i < flagsType.NumField(); i++ {
 		field := flagsType.Field(i)
@@ -218,8 +217,7 @@ func detectLanguageFromEnv() string {
 // writeAllFlags writes all flags with translated descriptions
 func (h *TranslatedHelpWriter) writeAllFlags() {
 	// Use direct reflection on the Flags struct to get all flag definitions
-	flags := &Flags{}
-	flagsType := reflect.TypeOf(flags).Elem()
+	flagsType := reflect.TypeFor[Flags]()
 
 	for i := 0; i < flagsType.NumField(); i++ {
 		field := flagsType.Field(i)

internal/plugins/ai/openai/openai_test.go

@@ -16,7 +16,7 @@ func TestBuildResponseRequestWithMaxTokens(t *testing.T) {
 
 	var msgs []*chat.ChatCompletionMessage
 
-	for i := 0; i < 2; i++ {
+	for range 2 {
 		msgs = append(msgs, &chat.ChatCompletionMessage{
 			Role:    "User",
 			Content: "My msg",
@@ -42,7 +42,7 @@ func TestBuildResponseRequestNoMaxTokens(t *testing.T) {
 
 	var msgs []*chat.ChatCompletionMessage
 
-	for i := 0; i < 2; i++ {
+	for range 2 {
 		msgs = append(msgs, &chat.ChatCompletionMessage{
 			Role:    "User",
 			Content: "My msg",

internal/plugins/template/text.go

@@ -16,7 +16,7 @@ func toTitle(s string) string {
 	lower := strings.ToLower(s)
 	runes := []rune(lower)
 
-	for i := 0; i < len(runes); i++ {
+	for i := range runes {
 		// Capitalize if previous char is non-letter AND
 		// (we're at the end OR next char is not space)
 		if i == 0 || !unicode.IsLetter(runes[i-1]) {