common-lisp/sbcl.sbcl
1
0
Fork 0
mirror of git://git.code.sf.net/p/sbcl/sbcl synced 2026-09-10 07:26:40 -04:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Remove clc instructions that do nothing

Browse source 
Assembly routines for generic +,-,* are not tail-callable so they
do not need to adhere to the Lisp function return convention.
This commit is contained in:
Douglas Katzman 2026-08-28 18:51:29 -04:00
parent 8b6a050b46
commit ca8de03628
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/assembly/x86-64/arith.lisp
View file

@ -60,7 +60,6 @@
(inst jmp :nz DO-STATIC-FUN) ; no - do generic
,@body
(inst clc) ; single-value return
(inst ret)
DO-STATIC-FUN
@ -70,7 +69,7 @@
(move res x)
(inst add res y)
(inst jmp :o BIGNUM)
(inst clc) (inst ret)
(inst ret)
BIGNUM
;; Unbox the overflowed result, recovering the correct sign from
;; the carry flag, then re-box as a bignum.
@ -83,7 +82,7 @@
(move res x)
(inst sub res y)
(inst jmp :o BIGNUM)
(inst clc) (inst ret)
(inst ret)
BIGNUM
;; Unbox the overflowed result, recovering the correct sign from
;; the carry flag, then re-box as a bignum.
@ -99,7 +98,7 @@
(inst imul y) ; result in edx:eax
(inst jmp :o BIGNUM)
(move res rax)
(inst clc) (inst ret)
(inst ret)
BIGNUM
(inst shrd rax rdx-tn n-fixnum-tag-bits) ; high bits from edx
@ -113,7 +112,7 @@
(emit-alloc-other nil thread-tn bignum-widetag (+ bignum-digits-offset 2) res)
(storew rax res bignum-digits-offset other-pointer-lowtag)
(storew rcx res (1+ bignum-digits-offset) other-pointer-lowtag)
(inst clc) (inst ret)
(inst ret)
SINGLE-WORD-BIGNUM
(return-single-word-bignum res res rax)))
@ -138,7 +137,7 @@
(+ (ash code-constants-offset word-shift)
(- other-pointer-lowtag)))
rip-tn))
(inst clc) (inst ret)
(inst ret)
GENERIC
(tail-call-lisp-fun '%negate 1))