Use INVOKE-RESTART, not EXIT, to bail out of test files

tests/aprof.impure.lisp

@@ -9,7 +9,7 @@
 ;;;; absolutely no warranty. See the COPYING and CREDITS files for
 ;;;; more information.
 
-#-(and x86-64 sb-thread (not win32)) (sb-ext:exit :code 104) ;; not implemented elsewhere
+#-(and x86-64 sb-thread (not win32)) (invoke-restart 'run-tests::skip-file) ;; not implemented elsewhere
 
 (defstruct fruitbasket x y z)
 (with-test (:name :aprof-smoketest-struct

tests/autoclose-stream.impure.lisp

@@ -3,7 +3,7 @@
 ;;; due to co-located tests.
 
 ;;; don't know how to check validity of a HANDLE in the win32 api
-#-unix (sb-ext:exit :code 104)
+#-unix (invoke-restart 'run-tests::skip-file)
 
 (defun fd-has-finalizer-p (fd)
   ;; Finalizer function can be:

tests/brothertree.impure.lisp

@@ -1,4 +1,4 @@
-#+interpreter (sb-ext:exit :code 104)
+#+interpreter (invoke-restart 'run-tests::skip-file)
 
 (let ((*evaluator-mode* :compile))
   (load "../src/code/brothertree.lisp"))

tests/callback.impure.lisp

@@ -18,7 +18,7 @@
 ;;; and :alien-callbacks is almost everywhere defined.
 ;;; However mips doesn't seem to correctly implement them,
 ;;; making the feature indicator somewhat useless)
-#+(or (not alien-callbacks) mips) (exit :code 104)
+#+(or (not alien-callbacks) mips) (invoke-restart 'run-tests::skip-file)
 
 ;;; simple callback for a function
 

tests/classoid-typep.impure.lisp

@@ -9,7 +9,7 @@
 ;;;; absoluely no warranty. See the COPYING and CREDITS files for
 ;;;; more information.
 
-#-sb-thread (sb-ext:exit :code 104)
+#-sb-thread (invoke-restart 'run-tests::skip-file)
 
 ;;; Using a fresh package as a namespace for classes is a quick-and-dirty
 ;;; way to create a class hierarchy without anonymous classes.

tests/clos-typechecking.impure.lisp

@@ -13,7 +13,7 @@
 ;;;; more information.
 
 ;;; Typechecking should be working, but it isn't.
-#+interpreter (sb-ext:exit :code 104)
+#+interpreter (invoke-restart 'run-tests::skip-file)
 
 (shadow 'slot)
 

tests/clos.impure.lisp

@@ -11,7 +11,7 @@
 ;;;; absolutely no warranty. See the COPYING and CREDITS files for
 ;;;; more information.
 
-#+interpreter (sb-ext:exit :code 104)
+#+interpreter (invoke-restart 'run-tests::skip-file)
 
 (load "compiler-test-util.lisp")
 (defpackage "CLOS-IMPURE"

tests/compiler.impure.lisp

@@ -20,7 +20,7 @@
 ;; or actually reasonable things to test.
 (when (and (eq sb-ext:*evaluator-mode* :interpret)
            (not (member :sb-fasteval *features*)))
-  (sb-ext:exit :code 104))
+  (invoke-restart 'run-tests::skip-file))
 
 (load "compiler-test-util.lisp")
 

tests/concurrent-syscalls.impure.lisp

@@ -1,4 +1,4 @@
-#-sb-thread (sb-ext:exit :code 104)
+#-sb-thread (invoke-restart 'run-tests::skip-file)
 (use-package "SB-THREAD")
 
 (defun exercise-syscall (fn reference-errno)

tests/deadlock.impure.lisp

@@ -1,4 +1,4 @@
-#-sb-thread (sb-ext:exit :code 104)
+#-sb-thread (invoke-restart 'run-tests::skip-file)
 
 (import '(sb-thread:join-thread
           sb-thread:make-mutex

tests/debug.impure.lisp

@@ -17,7 +17,7 @@
 
 ;;; The debugger doesn't have any native knowledge of the interpreter
 (when (eq sb-ext:*evaluator-mode* :interpret)
-  (sb-ext:exit :code 104))
+  (invoke-restart 'run-tests::skip-file))
 
 #+(or x86 x86-64)
 (with-test (:name :legal-bpt-lra-object)

tests/exhaust.impure.lisp

@@ -11,7 +11,7 @@
 ;;;; absolutely no warranty. See the COPYING and CREDITS files for
 ;;;; more information.
 
-#+interpreter (sb-ext:exit :code 104)
+#+interpreter (invoke-restart 'run-tests::skip-file)
 
 (test-util::disable-profiling)
 

tests/exit-hang.impure.lisp

@@ -1,4 +1,4 @@
-#+(or (not sb-thread) win32) (sb-ext:exit :code 104)
+#+(or (not sb-thread) win32) (invoke-restart 'run-tests::skip-file)
 
 ;;; Not an exactly an "exit hang" test, but there was a different hang
 ;;; regarding concurrent JOIN-THREAD on 1 thread.
@@ -74,4 +74,3 @@
 ;;; Give ourselves 3 seconds to exit.
 (alien-funcall (extern-alien "prepare_exit_test" (function void int)) 3)
 (setq sb-ext:*forcibly-terminate-threads-on-exit* nil)
-(exit :code 104)

tests/fast-eval.impure.lisp

@@ -11,8 +11,7 @@
 ;;;; absolutely no warranty. See the COPYING and CREDITS files for
 ;;;; more information.
 
-#-sb-fasteval
-(sb-ext:exit :code 104)
+#-sb-fasteval (invoke-restart 'run-tests::skip-file)
 
 (setf sb-ext:*evaluator-mode* :interpret)
 

tests/fcb-threads.impure.lisp

@@ -15,7 +15,7 @@
 ;;;  - garbage_collect: no SP known for thread 0x802bea000 (OS 34367133952)
 ;;;  - failed AVER: (NOT (SB-THREAD::AVL-FIND ADDR SB-THREAD::OLD))
 
-#+(or (not sb-thread) freebsd) (sb-ext:exit :code 104)
+#+(or (not sb-thread) freebsd) (invoke-restart 'run-tests::skip-file)
 
 (setf (generation-number-of-gcs-before-promotion 0) 5)
 (setf (generation-number-of-gcs-before-promotion 1) 3)
@@ -157,7 +157,7 @@
   (f 5 5 200 t))
 
 ;;; The next test hasn't been made to run on windows, but should.
-#+win32 (exit :code 104)
+#+win32 (invoke-restart 'run-tests::skip-file)
 
 ;;; Check that you get an error trying to join a foreign thread
 (defglobal *my-foreign-thread* nil)

tests/filecompile.impure.lisp

@@ -9,7 +9,7 @@
                                               (scratch-file-name "fasl")))))
         (assert (search expect err-string))))))
 
-#-sb-thread (sb-ext:exit :code 104)
+#-sb-thread (invoke-restart 'run-tests::skip-file)
 
 (unlock-package "SB-INT")
 (unlock-package "SB-IMPL")

tests/finalize.impure.lisp

@@ -1,5 +1,4 @@
-#+interpreter (sb-ext:exit :code 104)
-#+sb-safepoint (sb-ext:exit :code 104) ; tends to hang
+#+(or sb-safepoint interpreter) (invoke-restart 'run-tests::skip-file)
 
 (defvar *tmp* 0.0) ; don't remove - used by the setq below
 (defglobal *count* 0)

tests/full-eval.impure.lisp

@@ -11,8 +11,7 @@
 ;;;; absolutely no warranty. See the COPYING and CREDITS files for
 ;;;; more information.
 
-#-(or sb-eval sb-fasteval)
-(sb-ext:exit :code 104)
+#-(or sb-eval sb-fasteval) (invoke-restart 'run-tests::skip-file)
 
 (setf sb-ext:*evaluator-mode* :interpret)
 

tests/gc-search.impure.lisp

@@ -1,5 +1,5 @@
 
-#-immobile-space (sb-ext:exit :code 104)
+#-immobile-space (invoke-restart 'run-tests::skip-file)
 
 (defun make-page-full-of-fdefns ()
   ;; Make a bunch of fdefns until we're aligned at a page boundary.

tests/gc-threads.impure.lisp

@@ -1,4 +1,4 @@
-#-sb-thread (sb-ext:exit :code 104)
+#-sb-thread (invoke-restart 'run-tests::skip-file)
 
 (with-test (:name (:two-threads-running-gc)
                   :broken-on :sb-safepoint)

tests/gethash-concurrency.impure.lisp

@@ -1,6 +1,6 @@
 ;;; HASH TABLES
 
-#-sb-thread (sb-ext:exit :code 104)
+#-sb-thread (invoke-restart 'run-tests::skip-file)
 (use-package "SB-THREAD")
 (use-package "SB-SYS")
 

tests/immobile-space.impure.lisp

@@ -1,5 +1,5 @@
 
-#-immobile-space (sb-ext:exit :code 104)
+#-immobile-space (invoke-restart 'run-tests::skip-file)
 
 ;;; If an instance was allocated but its layout not stored yet
 ;;; it could crash

tests/interrupt-atomic-incf.impure.lisp

@@ -1,4 +1,4 @@
-#-sb-thread (sb-ext:exit :code 104)
+#-sb-thread (invoke-restart 'run-tests::skip-file)
 
 (use-package "SB-THREAD")
 

tests/interrupt-consing.impure.lisp

@@ -1,4 +1,4 @@
-#-sb-thread (sb-ext:exit :code 104)
+#-sb-thread (invoke-restart 'run-tests::skip-file)
 
 (use-package "SB-THREAD")
 

tests/interrupted-sleep.impure.lisp

@@ -1,4 +1,4 @@
-#-sb-thread (sb-ext:exit :code 104)
+#-sb-thread (invoke-restart 'run-tests::skip-file)
 
 ;; test that SLEEP actually sleeps for at least the given time, even
 ;; if interrupted by another thread exiting/a gc/anything

tests/kill-non-lisp-thread.impure.lisp

@@ -11,8 +11,7 @@
 ;;;; absolutely no warranty. See the COPYING and CREDITS files for
 ;;;; more information.
 
-#+(or :win32 (not :sb-thread))
-(sb-ext:exit :code 104)
+#+(or :win32 (not :sb-thread)) (invoke-restart 'run-tests::skip-file)
 
 (use-package :sb-alien)
 

tests/mutex.impure.lisp

@@ -1,4 +1,4 @@
-#-sb-thread (sb-ext:exit :code 104)
+#-sb-thread (invoke-restart 'run-tests::skip-file)
 
 (use-package "SB-THREAD")
 

tests/package-locks.impure.lisp

@@ -11,7 +11,7 @@
 ;;;; absolutely no warranty. See the COPYING and CREDITS files for
 ;;;; more information.
 
-#+sb-devel (sb-ext:exit :code 104) ; packages are not locked for devs
+#+sb-devel (invoke-restart 'run-tests::skip-file) ; packages are not locked for devs
 
 (load "compiler-test-util.lisp")
 

tests/session.impure.lisp

@@ -11,7 +11,7 @@
 ;;;; absoluely no warranty. See the COPYING and CREDITS files for
 ;;;; more information.
 
-#-sb-thread (sb-ext:exit :code 104)
+#-sb-thread (invoke-restart 'run-tests::skip-file)
 
 (setf sb-unix::*on-dangerous-wait* :error)
 

tests/sprof.impure.lisp

@@ -5,7 +5,7 @@
 ;;; but I need to try to see it behaving badly (if it does),
 ;;; and there's really no other way than to watch for bad output.
 
-#+win32 (sb-ext:exit :code 104)
+#+win32 (invoke-restart 'run-tests::skip-file)
 
 (require :sb-sprof)
 (load "../contrib/sb-sprof/test.lisp")

tests/style-warnings.impure.lisp

@@ -17,7 +17,7 @@
 ;;;; more information.
 
 ;; These tests don't work unless compiling
-#+interpreter (sb-ext:exit :code 104)
+#+interpreter (invoke-restart 'run-tests::skip-file)
 
 (defun f-with-macro (arg) (list arg))
 (defun f2-with-macro (a b) (list a b))

tests/system.impure.lisp

@@ -11,7 +11,7 @@
 
 (in-package "SB-VM")
 
-#-(and (or x86 x86-64) (not interpreter)) (sb-ext:exit :code 104)
+#-(and (or x86 x86-64) (not interpreter)) (invoke-restart 'run-tests::skip-file)
 
 (test-util:with-test (:name :basic-cpuid)
   (flet ((to-ascii (bits)

tests/threads.impure.lisp

@@ -70,7 +70,7 @@
     (process-all-interrupts))
   (check-deferrables-unblocked-or-lose 0))
 
-#-sb-thread (sb-ext:exit :code 104)
+#-sb-thread (invoke-restart 'run-tests::skip-file)
 
 ;;;; Now the real tests...
 

tests/timer.impure.lisp

@@ -9,7 +9,7 @@
 ;;;; absolutely no warranty. See the COPYING and CREDITS files for
 ;;;; more information.
 
-#+interpreter (sb-ext:exit :code 104)
+#+interpreter (invoke-restart 'run-tests::skip-file)
 
 (with-test (:name :heap)
   (let* ((size 1000)

tests/traceroot.impure.lisp

@@ -18,7 +18,7 @@
 ;;;; And also sb-safepoint gets a crash in C.
 #-(and gencgc sb-thread (not sb-safepoint)
        (or (and arm64 (not darwin)) ppc64 x86-64))
-(sb-ext:exit :code 104)
+(invoke-restart 'run-tests::skip-file)
 
 (setq sb-ext:*evaluator-mode* :compile)
 (defvar *fred*)

tests/unwind-to-frame-and-call.impure.lisp

@@ -14,7 +14,7 @@
 
 ;;; The debugger doesn't have any native knowledge of the interpreter
 (when (eq sb-ext:*evaluator-mode* :interpret)
-  (sb-ext:exit :code 104))
+  (invoke-restart 'run-tests::skip-file))
 
 (declaim (optimize debug))
 

tests/win32-foreign-stack-unwind.impure.lisp

@@ -11,8 +11,8 @@
 ;;;; absolutely no warranty. See the COPYING and CREDITS files for
 ;;;; more information.
 
-#-win32 (exit :code 104) ;; This is extremely win32-specific.
-#-x86   (exit :code 104) ;; And our AMD64 backend does not aim to support it.
+#-win32 (invoke-restart 'run-tests::skip-file) ;; This is extremely win32-specific.
+#-x86   (invoke-restart 'run-tests::skip-file) ;; And our AMD64 backend does not aim to support it.
 
 (use-package :sb-alien)
 

tests/win32.impure.lisp

@@ -9,7 +9,7 @@
 ;;;; absolutely no warranty. See the COPYING and CREDITS files for
 ;;;; more information.
 
-#-win32 (exit :code 104)
+#-win32 (invoke-restart 'run-tests::skip-file)
 
 (with-test (:name :dbg-print-exception-c)
   (handler-case

tests/win64-exceptions.impure.lisp

@@ -11,7 +11,7 @@
 ;;;; absolutely no warranty. See the COPYING and CREDITS files for
 ;;;; more information.
 
-#-(and win32 x86-64) (exit :code 104) ;; This is extremely win64-specific.
+#-(and win32 x86-64) (invoke-restart 'run-tests::skip-file) ;; This is extremely win64-specific.
 
 (with-scratch-file (dll "dll")
   (run-program "gcc" `("-shared" "-o" ,dll "win64-exceptions.c")

tests/x86-64-codegen.impure.lisp

@@ -9,7 +9,7 @@
 ;;;; absolutely no warranty. See the COPYING and CREDITS files for
 ;;;; more information.
 
-#-x86-64 (sb-ext:exit :code 104)
+#-x86-64 (invoke-restart 'run-tests::skip-file)
 
 ;;; This trivial function failed to compile due to rev 88d078fe
 (defun foo (&key k)