mirror of
git://git.code.sf.net/p/sbcl/sbcl
synced 2026-09-10 07:26:40 -04:00
db187b0e29
Reduces SYMBOL-VALUE to exactly 2 instructions for most specials that aren't compile-time known to be either always thread-local or global. Our application got a .5% reduction in code size and about a 1% speedup. Refer to the comment above EMIT-SYMEVAL in src/compiler/x86-64/tls for details. When eager TLS assignment is also enabled, this optimization pertains to every special var except when the symbol itself is not known. I'm not sure how to expose the extra benefit that comes from eager TLS assignment because even if recycling indices were done, there would certainly be users who DEFVAR thousands of interned symbols without LET-binding a single one of them. So they need lazy TLS assignment.
97 lines
3.7 KiB
Bash
97 lines
3.7 KiB
Bash
. ./subr.sh
|
|
|
|
use_test_subdirectory
|
|
|
|
tmpcore=$TEST_FILESTEM.core
|
|
|
|
echo "::: Running :SAVE-CORE-MEM-SIZES"
|
|
# executable core used as "--core" option should not save the memory sizes
|
|
# that were originally saved, but the sizes in the process doing the save.
|
|
run_sbcl_with_args --noinform --control-stack-size 384KB --dynamic-space-size 260MB \
|
|
--disable-debugger --no-userinit --no-sysinit --noprint <<EOF
|
|
(save-lisp-and-die "$tmpcore" :executable t :save-runtime-options t)
|
|
EOF
|
|
chmod u+x "$tmpcore"
|
|
echo "::: INFO: prepared test core"
|
|
./"$tmpcore" --no-userinit --no-sysinit --noprint <<EOF
|
|
(assert (eql (extern-alien "thread_control_stack_size" unsigned) (* 384 1024)))
|
|
; allow slight shrinkage if heap relocation has to adjust for alignment
|
|
(assert (<= 0 (- (* 260 1048576) (dynamic-space-size)) 65536))
|
|
EOF
|
|
if [ $? -ne 0 ]; then
|
|
exit 1
|
|
fi
|
|
echo "::: Success"
|
|
|
|
run_sbcl_with_args --noinform --control-stack-size 384KB --dynamic-space-size 260MB \
|
|
--disable-debugger --no-userinit --no-sysinit --noprint <<EOF
|
|
(save-lisp-and-die "$tmpcore" :executable t :save-runtime-options :accept-runtime-options)
|
|
EOF
|
|
chmod u+x "$tmpcore"
|
|
|
|
echo "::: Running :ACCEPT-MEMORY-SIZES"
|
|
# next, check that tmpcore will accept memory size options.
|
|
# Use --control-stack-size for the test, since we don't know the valid range
|
|
# of dynamic space size for the OS/arch.
|
|
# Test that we find the arg in the midst of the command-line args as well.
|
|
./"$tmpcore" --no-userinit --control-stack-size 3MB --no-sysinit --noprint <<EOF
|
|
(assert (eql (extern-alien "thread_control_stack_size" unsigned) (* 3 1048576)))
|
|
EOF
|
|
if [ $? -ne 0 ]; then
|
|
exit 1
|
|
fi
|
|
echo "::: Success"
|
|
|
|
echo "::: Running :DASH-DASH-STOP-PARSING"
|
|
# Test that we don't parse after a "--"
|
|
./"$tmpcore" --no-userinit --no-sysinit --noprint -- --dynamic-space-size 1000GB foo <<EOF
|
|
(let* ((end (sb-vm::current-thread-offset-sap sb-vm::thread-control-stack-end-slot))
|
|
(start (sb-vm::current-thread-offset-sap sb-vm::thread-control-stack-start-slot))
|
|
(diff (sb-sys:sap- end start)))
|
|
;; We better not have gotten a terabyte of dynamic space!
|
|
(assert (< diff (* 8 1024 1024 1024))) ; assert less than 8GB
|
|
(assert (find "--" sb-ext:*posix-argv* :test 'string=)))
|
|
EOF
|
|
if [ $? -ne 0 ]; then
|
|
exit 1
|
|
fi
|
|
echo "::: Success"
|
|
|
|
echo "::: Running :DYNAMIC-SPACE-SIZE-ARG"
|
|
run_sbcl_with_core "$tmpcore" --noinform --control-stack-size 640KB \
|
|
--tls-limit 5000 \
|
|
--dynamic-space-size 260MB --no-userinit --no-sysinit --noprint <<EOF
|
|
(defconstant tls-element-size
|
|
(* (if (find :tls-load-indirect sb-impl:+internal-features+) 2 1)
|
|
sb-vm:n-word-bytes))
|
|
(assert (eql (extern-alien "thread_control_stack_size" unsigned) (* 640 1024)))
|
|
(assert (eql (extern-alien "dynamic_values_bytes" (unsigned 32))
|
|
(* 5000 tls-element-size)))
|
|
; allow slight shrinkage if heap relocation has to adjust for alignment
|
|
(defun dynamic-space-size-good-p ()
|
|
(<= 0 (- (* 260 1048576) (dynamic-space-size)) 65536))
|
|
(assert (dynamic-space-size-good-p))
|
|
(save-lisp-and-die "${tmpcore}2" :executable t :save-runtime-options t)
|
|
EOF
|
|
chmod u+x "${tmpcore}2"
|
|
echo "::: INFO: prepared test core"
|
|
./"${tmpcore}2" --no-userinit --no-sysinit --noprint <<EOF
|
|
(defconstant tls-element-size
|
|
(* (if (find :tls-load-indirect sb-impl:+internal-features+) 2 1)
|
|
sb-vm:n-word-bytes))
|
|
(when (and (eql (extern-alien "thread_control_stack_size" unsigned) (* 640 1024))
|
|
(eql (extern-alien "dynamic_values_bytes" (unsigned 32))
|
|
(* 5000 tls-element-size))
|
|
(dynamic-space-size-good-p))
|
|
(exit :code 42))
|
|
EOF
|
|
status=$?
|
|
rm "$tmpcore" "${tmpcore}2"
|
|
if [ $status -ne 42 ]; then
|
|
echo "re-saved executable used wrong memory size options"
|
|
exit 1
|
|
fi
|
|
echo "::: Success"
|
|
|
|
exit $EXIT_TEST_WIN
|