emacs/gnu.emacs
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/emacs.git synced 2026-09-10 15:56:35 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Ensure the correct current buffer in completions--background-update

Browse source 
* lisp/minibuffer.el (completions--background-update):
Add new arg 'buffer' and compare it with 'current-buffer'.
(completions--start-background-update): Run an idle timer
for 'completions--background-update' with a new arg
set to 'current-buffer' that ensures that the timer function
is run in the same buffer (bug#81349).
This commit is contained in:
Juri Linkov 2026-07-10 18:56:39 +03:00
parent d0bd9b39a3
commit 9ebc5b9d93
1 changed files with 15 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
lisp/minibuffer.el
View file

@ -2764,22 +2764,24 @@ is always true."
(defvar completions--background-update-timer nil)
(defun completions--background-update (force-eager-update)
(defun completions--background-update (force-eager-update buffer)
"Try to update *Completions* without blocking input.
This function uses `while-no-input' and sets `non-essential' to t
so that the update is less likely to interfere with user typing."
(setq completions--background-update-timer nil)
(when (while-no-input
(let ((non-essential t))
(redisplay)
(cond
(completion-in-region-mode (completion-help-at-point t))
((completions--should-show-p
(completion--field-metadata (minibuffer-prompt-end))
force-eager-update)
(minibuffer-completion-help))))
nil)
(when (and
(eq buffer (current-buffer))
(while-no-input
(let ((non-essential t))
(redisplay)
(cond
(completion-in-region-mode (completion-help-at-point t))
((completions--should-show-p
(completion--field-metadata (minibuffer-prompt-end))
force-eager-update)
(minibuffer-completion-help))))
nil))
;; If we got interrupted, try again the next time the user is idle.
(completions--start-background-update force-eager-update)))
@ -2797,7 +2799,8 @@ If FORCE-EAGER-UPDATE is non-nil, we only check eager-display."
(unless completions--background-update-timer
(setq completions--background-update-timer
(run-with-idle-timer
0 nil #'completions--background-update force-eager-update))))
0 nil #'completions--background-update
force-eager-update (current-buffer)))))
(defun completions--start-eager-display ()
"Maybe display the *Completions* buffer when the user is next idle.