emacs/gnu.emacs
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/emacs.git synced 2026-09-10 07:46:51 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix blinking Eldoc messages

Browse source 
Ensure that `global-eldoc-mode' does not enable `eldoc-mode' in
ephemeral Eldoc buffers and accidentally reset `eldoc-last-message'.
This caused Eldoc message blinking (bug#81356).

* lisp/emacs-lisp/eldoc.el (eldoc--supported-p): Exclude ephemeral Eldoc
buffers to avoid blinking.
(eldoc-help-at-pt): Add custom :set function.
(eldoc-documentation-functions): Do not register `eldoc-show-help-at-pt'
by default.
This commit is contained in:
Daniel Mendler 2026-07-05 17:51:13 +02:00 committed by Eli Zaretskii
parent 3e7908fe23
commit ba781ed754
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
lisp/emacs-lisp/eldoc.el
View file

@ -144,6 +144,11 @@ This setting is an alternative to `help-at-pt-display-when-idle'. If
the value is non-nil, `eldoc-show-help-at-pt' will show help-at-point
via Eldoc."
:type 'boolean
:set (lambda (sym val)
(custom-set-default sym val)
(if val
(add-hook 'eldoc-documentation-functions #'eldoc-show-help-at-pt 90)
(remove-hook 'eldoc-documentation-functions #'eldoc-show-help-at-pt)))
:version "31.1")
(defface eldoc-highlight-function-argument
@ -417,7 +422,7 @@ Also store it in `eldoc-last-message' and return that value."
(overlay-end show-paren--overlay)))))))
(defvar eldoc-documentation-functions (list #'eldoc-show-help-at-pt)
(defvar eldoc-documentation-functions nil
"Hook of functions that produce doc strings.
A doc string is typically relevant if point is on a function-like
@ -813,7 +818,9 @@ all."
(defun eldoc--supported-p ()
"Non-nil if an ElDoc function is set for this buffer."
(and (not (memq eldoc-documentation-strategy '(nil ignore)))
;; Exclude ephemeral *eldoc* buffers, to avoid blinking (bug#81356).
(and (not (string-prefix-p " *eldoc" (buffer-name)))
(not (memq eldoc-documentation-strategy '(nil ignore)))
(or eldoc-documentation-functions
;; The old API had major modes set `eldoc-documentation-function'
;; to provide eldoc support. It's impossible now to determine