Make denote--dir-in-denote-directory-p more robust

This is in response to a bug reported by Kevin Izevbigie in issue 705:
<https://github.com/protesilaos/denote/issues/705>.
This commit is contained in:
Protesilaos 2026-05-12 13:18:27 +03:00
parent d7dab477a1
commit 21b1c81d1a
No known key found for this signature in database
GPG key ID: 99BD6459CD5CA3EA
2 changed files with 13 additions and 12 deletions

View file

@ -7148,17 +7148,17 @@ Denote is meant to be a collective effort. Every bit of help matters.
IceAsteroid, Jack Baty, Jay Rajput, Jean-Charles Bagneris, Jeff IceAsteroid, Jack Baty, Jay Rajput, Jean-Charles Bagneris, Jeff
Valk, Jens Östlund, Jeremy Friesen, Jonathan Sahar, Johan Bolmsjö, Valk, Jens Östlund, Jeremy Friesen, Jonathan Sahar, Johan Bolmsjö,
Jonas Großekathöfer, Jousimies, Juanjo Presa, Julian Hoch, Kai von Jonas Großekathöfer, Jousimies, Juanjo Presa, Julian Hoch, Kai von
Fintel, Kaushal Modi, Kolmas, Lukas C. Bossert, M. Hadi Timachi, Fintel, Kaushal Modi, Kevin Izevbigie, Kolmas, Lukas C. Bossert, M.
Maikol Solis, Mark Olson, Michael Jones, Mirko Hernandez, Morten Hadi Timachi, Maikol Solis, Mark Olson, Michael Jones, Mirko
Kjeldgaard, Niall Dooley, Nick Bell, Oliver Epper, Paul van Gelder, Hernandez, Morten Kjeldgaard, Niall Dooley, Nick Bell, Oliver Epper,
Peter Prevos, Peter Smith, Riccardo Giannitrapani, Rory Molinari, Paul van Gelder, Peter Prevos, Peter Smith, Riccardo Giannitrapani,
Samuel W. Flint, Sergio Rey, Suhail Singh, Shreyas Ragavan, Stefan Rory Molinari, Samuel W. Flint, Sergio Rey, Suhail Singh, Shreyas
Thesing, Summer Emacs, Sven Seebeck, Taoufik, TJ Stankus, Vick Ragavan, Stefan Thesing, Summer Emacs, Sven Seebeck, Taoufik, TJ
(VicZz), Viktor Haag, Vineet C. Kulkarni, Wade Mealing, Wilf, Yi Stankus, Vick (VicZz), Viktor Haag, Vineet C. Kulkarni, Wade
Liu, Ypot, 82Kang, atanasj, azegas, babusri, bdillahu, Mealing, Wilf, Yi Liu, Ypot, 82Kang, atanasj, azegas, babusri,
coherentstate, doolio, duli, drcxd, elge70, elliottw, fingerknight, bdillahu, coherentstate, doolio, duli, drcxd, elge70, elliottw,
GuutBoy, hpgisler, hyperfocus1337,johkneisl, jtpavlock, juh, fingerknight, GuutBoy, hpgisler, hyperfocus1337,johkneisl,
leafarbelm, mentalisttraceur, mjkalyan, oatmealm, jtpavlock, juh, leafarbelm, mentalisttraceur, mjkalyan, oatmealm,
Pratik-Mishra-4979, pRot0ta1p, rbenit68, relict007, sarcom-sar, Pratik-Mishra-4979, pRot0ta1p, rbenit68, relict007, sarcom-sar,
sienic, skissue, sundar bp, wuzhihao, yetanotherfossman, zadca123 sienic, skissue, sundar bp, wuzhihao, yetanotherfossman, zadca123

View file

@ -3107,7 +3107,8 @@ TEMPLATE, and SIGNATURE should be valid for note creation."
"Return non-nil if DIRECTORY is in variable `denote-directory'." "Return non-nil if DIRECTORY is in variable `denote-directory'."
(seq-some (seq-some
(lambda (d) (lambda (d)
(string-prefix-p d (expand-file-name directory))) (or (string-prefix-p d (file-name-as-directory (expand-file-name directory)))
(string-prefix-p (file-name-as-directory (expand-file-name directory)) d)))
(denote-directories))) (denote-directories)))
(defun denote--valid-file-type (filetype) (defun denote--valid-file-type (filetype)