emacs/protesilaos.denote
1
0
Fork 0
mirror of https://github.com/protesilaos/denote.git synced 2026-09-10 07:16:20 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Rewrite denote-sequence--get-new-sibling to address its bugs

Browse source
This commit is contained in:
Protesilaos Stavrou 2024-12-31 11:57:17 +02:00
parent 6a43e5cad5
commit 43322b34aa
No known key found for this signature in database
GPG key ID: 99BD6459CD5CA3EA
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
denote-sequence.el
View file

@ -189,14 +189,24 @@ function `denote-sequence-get-all-sequences-with-prefix'."
(format "%s=1" largest)))) (format "%s=1" largest))))
(error "Cannot find sequences given sequence `%s'" sequence))) (error "Cannot find sequences given sequence `%s'" sequence)))
(defun denote-sequence--get-prefix-for-siblings (sequence)
"Get the prefix of SEQUENCE such that it is possible to find its siblings."
(when (string-match-p "=" sequence)
(mapconcat #'identity (butlast (denote-sequence-split sequence)) "=")))
(defun denote-sequence--get-new-sibling (sequence &optional sequences) (defun denote-sequence--get-new-sibling (sequence &optional sequences)
"Return a new sibling SEQUENCE. "Return a new sibling SEQUENCE.
Optional SEQUENCES has the same meaning as that specified in the Optional SEQUENCES has the same meaning as that specified in the
function `denote-sequence-get-all-sequences-with-prefix'." function `denote-sequence-get-all-sequences-with-prefix'."
(let* ((children-p (string-match-p "=" sequence))) (let* ((children-p (string-match-p "=" sequence)))
(if-let* ((all (if children-p (if-let* ((depth (denote-sequence-depth sequence))
(denote-sequence-get-all-sequences-with-prefix sequence sequences) (all-unfiltered (if children-p
(denote-sequence-get-all-sequences))) (denote-sequence-get-all-sequences-with-prefix
(denote-sequence--get-prefix-for-siblings sequence)
sequences)
(denote-sequence-get-all-sequences)))
(all (denote-sequence-get-sequences-with-max-depth depth all-unfiltered))
((member sequence all))
(largest (if children-p (largest (if children-p
(denote-sequence--get-largest all 'sibling) (denote-sequence--get-largest all 'sibling)
(denote-sequence--get-largest all 'parent)))) (denote-sequence--get-largest all 'parent))))