emacs/protesilaos.denote
1
0
Fork 0
mirror of https://github.com/protesilaos/denote.git synced 2026-09-15 09:46:24 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix: Ensure signature is sluggified correctly when renaming

Browse source 
Based on the bug found in the previous commit, I looked at all the
call-sites for `denote-sluggify-signature` and
`denote-retrieve-filename-signature` and found two other places:

1. `denote-rename-file`: Add check to ensure signature exists when
   trying to sluggify it.

2. `denote-rename-file-using-front-matter`: Sluggify the signature
   before creating the new file-name.
This commit is contained in:
Vedang Manerikar 2023-11-17 20:57:00 +05:30 committed by Protesilaos Stavrou
parent dee430a586
commit 6caf8755eb
No known key found for this signature in database
GPG key ID: 99BD6459CD5CA3EA
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
denote.el
View file

@ -2429,7 +2429,7 @@ place."
(title (or title (denote--retrieve-title-or-filename file file-type)))
(keywords (or keywords (denote-retrieve-keywords-value file file-type)))
(signature (or signature (denote-retrieve-filename-signature file)))
(new-name (denote-format-file-name dir id keywords (denote-sluggify title 'title) extension (denote-sluggify-signature signature)))
(new-name (denote-format-file-name dir id keywords (denote-sluggify title 'title) extension (when signature (denote-sluggify-signature signature))))
(max-mini-window-height denote-rename-max-mini-window-height))
(when (or denote-rename-no-confirm (denote-rename-file-prompt file new-name))
(denote-rename-file-and-buffer file new-name)
@ -2573,7 +2573,7 @@ does internally."
(signature (denote-retrieve-filename-signature file))
(extension (denote-get-file-extension file))
(dir (file-name-directory file))
(new-name (denote-format-file-name dir id keywords sluggified-title extension signature)))
(new-name (denote-format-file-name dir id keywords sluggified-title extension (when signature (denote-sluggify-signature signature)))))
(when (or auto-confirm
(denote-rename-file-prompt file new-name))
(denote-rename-file-and-buffer file new-name)