emacs/protesilaos.denote
1
0
Fork 0
mirror of https://github.com/protesilaos/denote.git synced 2026-09-15 17:56:19 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Stop using the 'denote--rename-file-subr' in 'denote-rename-file'

Browse source 
That abstraction was not good enough and thus makes things more
difficult for us. I am reverting to what we had before. We will see
how best to proceed.

Thanks to Jean-Philippe Gagné Guay for telling me about the drawbacks
of the 'denote--rename-file-subr'. This was done on the GitHub mirror.
This commit is contained in:
Protesilaos Stavrou 2023-11-04 05:01:01 +02:00
parent 0d7b81955d
commit bd3ddfbe42
No known key found for this signature in database
GPG key ID: 99BD6459CD5CA3EA
1 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
denote.el
View file

@ -2457,7 +2457,23 @@ place."
(denote-retrieve-filename-signature file)
(format "Rename `%s' with signature (empty to ignore)" file-in-prompt))
current-prefix-arg)))
(denote--rename-file-subr file nil title keywords signature ask-date))
(let* ((dir (file-name-directory file))
(id (or (denote-retrieve-filename-identifier file :no-error)
(denote-create-unique-file-identifier file ask-date)))
(extension (denote-get-file-extension file))
(file-type (denote-filetype-heuristics file))
(title (or title (denote--retrieve-title-or-filename file file-type)))
(keywords (or keywords (denote-retrieve-keywords-value file file-type)))
(signature (or signature (denote-retrieve-filename-signature file)))
(new-name (denote-format-file-name dir id keywords (denote-sluggify title 'title) extension signature))
(max-mini-window-height denote-rename-max-mini-window-height))
(when (denote-rename-file-prompt file new-name)
(denote-rename-file-and-buffer file new-name)
(denote-update-dired-buffers)
(when (denote-file-is-writable-and-supported-p new-name)
(if (denote--edit-front-matter-p new-name file-type)
(denote-rewrite-front-matter new-name title keywords file-type)
(denote--add-front-matter new-name title keywords id file-type))))))
;;;###autoload
(defun denote-dired-rename-files ()