emacs/protesilaos.denote
1
0
Fork 0
mirror of https://github.com/protesilaos/denote.git synced 2026-09-10 07:16:20 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix error when following non-Denote Markdown links

Browse source 
When following links in markdown-mode that are to non-Denote resources
like URLs, you would see the error:

    Cannot open ‘nil’ of unknown link type

That is because Denote adds denote-link-markdown-follow to
markdown-follow-link-functions, which eventually calls
denote--act-on-query-link with a nil value.

To solve this, we return nil from denote-link-markdown-follow when we do
not know how to handle the link. That lets markdown-mode try its link
handling. Per the markdown-follow-link-functions documentation, we
should "return non-nil if [we] followed the link, or nil if not."
This commit is contained in:
bplubell 2026-03-18 15:36:56 -07:00
parent 76c2e27e80
commit d8c2488622
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
denote.el
View file

@ -6367,10 +6367,11 @@ Return either nil or a list whose elements are two cons cells:
This is the subroutine of `denote-link-open-at-point' and
`denote-link-open-at-mouse'."
(pcase-let* ((data (denote--link-at-point-get-data position))
(`(,target . ,_) (car data)))
(if-let* ((path (denote-get-path-by-id target)))
(funcall denote-open-link-function path)
(denote--act-on-query-link target))))
(`(,target . ,_) (car data))
(path (denote-get-path-by-id target)))
(cond
(path (funcall denote-open-link-function path))
(target (denote--act-on-query-link target)))))
(defun denote-link-open-at-point ()
"Open Denote link at point."