emacs/protesilaos.denote
1
0
Fork 0
mirror of https://github.com/protesilaos/denote.git synced 2026-09-10 07:16:20 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix Windows compatibility of denote-link-ol-follow

Browse source 
On Windows, given the `link` as an identifer `"20250312T161853"` , the result of `(denote-link--ol-resolve-link-to-target 
 link)` is a Windows path `"c:/path/to/the/file.extension"`

However, the result of `(file-exists-p (string-trim-right match ":.*"))` is `nil`, because `(string-trim-right "c:/path/to/the/file.extension" ":.*")` returns `"c"` ,which is the driver letter on Windows.

We can fix it by this: `(string-trim-right "c:/path/to/the/file.extension" ":[^/]+.*")`
This commit is contained in:
TomoeMami 2025-04-14 13:41:26 +08:00 committed by GitHub
parent 956f5dfd10
commit da64be1a49
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
denote.el
View file

@ -6082,7 +6082,7 @@ query of file contents or file names (see the commands
Uses the function `denote-directory' to establish the path to the file."
(if-let* ((match (denote-link--ol-resolve-link-to-target link))
(_ (file-exists-p (string-trim-right match ":.*"))))
(_ (file-exists-p (string-trim-right match ":[^/]+.*"))))
(org-link-open-as-file match nil)
(denote--act-on-query-link match)))