emacs/protesilaos.denote
1
0
Fork 0
mirror of https://github.com/protesilaos/denote.git synced 2026-09-10 07:16:20 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use correct optional parameter in denote-link-ol-store (amend commit 20005e6)

Browse source 
Thanks to duli for the feedback in issue 552: <https://github.com/protesilaos/denote/issues/552>.
This commit is contained in:
Protesilaos Stavrou 2025-03-01 09:10:48 +02:00
parent 4ade384c03
commit e83ab6f106
No known key found for this signature in database
GPG key ID: 99BD6459CD5CA3EA
1 changed files with 29 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
denote.el
View file

@ -5420,34 +5420,37 @@ create a new one."
(format "%s::%s" file-text heading-text))
;;;###autoload
(defun denote-link-ol-store (&rest _)
(defun denote-link-ol-store (&optional interactive?)
"Handler for `org-store-link' adding support for denote: links.
Optional INTERACTIVE? is used by `org-store-link'.
Also see the user option `denote-org-store-link-to-heading'."
(when-let* ((file (buffer-file-name))
((denote-file-is-note-p file))
(file-id (denote-retrieve-filename-identifier file))
(description (denote-get-link-description file)))
(let ((heading-links (and denote-org-store-link-to-heading
(derived-mode-p 'org-mode)
(denote--org-capture-link-specifiers-p)))
(heading (denote-link-ol-get-heading)))
(org-link-store-props
:type "denote"
:description (if (and heading-links heading)
(denote-link-format-heading-description
description
heading)
description)
:link (cond
((when-let* ((id (org-entry-get (point) "CUSTOM_ID")))
(format "denote:%s::#%s" file-id id)))
((and heading-links (eq denote-org-store-link-to-heading 'context) heading)
(format "denote:%s::*%s" file-id heading))
((and heading-links heading)
(format "denote:%s::#%s" file-id (denote-link-ol-get-id)))
(t
(concat "denote:" file-id))))
org-store-link-plist)))
(when interactive?
(when-let* ((file (buffer-file-name))
((denote-file-is-note-p file))
(file-id (denote-retrieve-filename-identifier file))
(description (denote-get-link-description file)))
(let ((heading-links (and denote-org-store-link-to-heading
(derived-mode-p 'org-mode)
(denote--org-capture-link-specifiers-p)))
(heading (denote-link-ol-get-heading)))
(org-link-store-props
:type "denote"
:description (if (and heading-links heading)
(denote-link-format-heading-description
description
heading)
description)
:link (cond
((when-let* ((id (org-entry-get (point) "CUSTOM_ID")))
(format "denote:%s::#%s" file-id id)))
((and heading-links (eq denote-org-store-link-to-heading 'context) heading)
(format "denote:%s::*%s" file-id heading))
((and heading-links heading)
(format "denote:%s::#%s" file-id (denote-link-ol-get-id)))
(t
(concat "denote:" file-id))))
org-store-link-plist))))
;;;###autoload
(defun denote-link-ol-export (link description format)