emacs/protesilaos.denote
1
0
Fork 0
mirror of https://github.com/protesilaos/denote.git synced 2026-09-10 07:16:20 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve rename prompt; only rename regular files

Browse source 
Thanks to Frank Ehmsen for the feedback on the mailing list:
<https://lists.sr.ht/~protesilaos/denote/%3C9deea16e-d0d0-91b0-2b6a-0b8276406c6c@eh-is.de%3E>.
This commit is contained in:
Protesilaos Stavrou 2022-06-17 21:19:21 +03:00
parent 8d504a3264
commit f21a99775d
No known key found for this signature in database
GPG key ID: 99BD6459CD5CA3EA
1 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
denote-dired.el
View file

@ -194,6 +194,22 @@ everything works as intended."
(with-selected-window win
(find-file new-name)))))))
(defun denote-dired--rename-dired-file-or-prompt ()
"Return Dired file at point, else prompt for one."
(or (dired-get-filename nil t)
(let* ((file (buffer-file-name))
(format (if file
(format "Rename file Denote-style [%s]: " file)
"Rename file Denote-style: ")))
(read-file-name format nil file t nil))))
(defun denote-dired--rename-file-is-regular (file)
"Throw error is FILE is not regular, else return FILE."
(if (or (file-directory-p file)
(not (file-regular-p file)))
(user-error "Only rename regular files")
file))
;;;###autoload
(defun denote-dired-rename-file (file title keywords)
"Rename FILE to include TITLE and KEYWORDS.
@ -225,7 +241,7 @@ notes, (ii) complement note-taking, such as by renaming
attachments that the user adds to their notes."
(interactive
(list
(or (dired-get-filename nil t) (read-file-name "Rename file Denote-style: "))
(denote-dired--rename-file-is-regular (denote-dired--rename-dired-file-or-prompt))
(denote--title-prompt)
(denote--keywords-prompt)))
(let* ((dir (file-name-directory file))