I tried to do this with a recent commit but that broke things because
I also included a deftheme declaration. Having that meant that
modus-themes-theme would not declare the theme with all its data,
including its palette.
I looked at loaddefs-generate--emacs-batch and it seems that having
just the theme-autoload line is enough.
This reverts commit a4b5f93530.
The reason is that this breaks the package when trying to load a theme
at startup. This was reported by Eamonn Sullivan in issue 69 in the
ef-themes repository: <https://github.com/protesilaos/ef-themes/issues/69>.
It is not needed. I had it there because some colour no longer had the
same mappings after refactoring the themes to be built on top of
Modus. But I am in the process of reviewing those colours now.
I did the changes with keyboard macros as usual. I now notice that
some themes have 26 changes while others have 28. This should probably
be due to some older inconsequential irregularities. I loaded each
theme right now and they all seem okay, so I will let this pass. If
anybody reports a bug, I am always happy to fix it.
At any rate, the main point for this change is to (i) ensure that we
get a complete palette while (ii) that we register the theme's palette
as a "core palette" because these are the correct semantics (e.g. that
ef-light ultimately may have inherited something from modus-operandi
is not relevant to the question "what is your core theme?").
ef-kassio also had a different notice about whether this file is part
of Emacs. I remember reading before that GNU ELPA packages are part of
Emacs, though I prefer to have that notice only if they are part of
emacs.git.
The goal is two-fold:
1. Improve the semantics of relevant faces. This now covers the Org
agenda. We want pending/urgent tasks to be rendered in a bold font
and use a vivid colour. Whereas tasks that are not urgent should
have a subtle colour and a normal weight. Thanks to Adam
Porter (GitHub @alphapapa) for discussing this with me in issue
102 on the Modus themes repository (the same principles apply
here): <https://github.com/protesilaos/modus-themes/issues/102>.
2. Make the applicable colours be more consistent with the rest of the
theme. In practice, this means that the colour values are cooler
overall and the intensity is lower.
