Update to version 2.7.0

2026-09-10 07:16:30 -04:00 · 2022-10-01 10:24:44 +03:00 · 2022-10-01 10:24:44 +03:00 · 1d55785ab0
parent a7c17f36f1
commit 1d55785ab0
4 changed files with 240 additions and 66 deletions
--- a/CHANGELOG.org
+++ b/CHANGELOG.org
@ -15,6 +15,182 @@ For further details, please consult these additional resources:
 + Manual :: <https://protesilaos.com/emacs/modus-themes>
 + Screenshots :: <https://protesilaos.com/emacs/modus-themes-pictures>

+* 2.7.0
+:PROPERTIES:
+:CUSTOM_ID: h:4d86106c-1df5-4f5f-bc6c-f14f5d13403b
+:END:
+
+#+begin_src text
+Modus themes version 2.7.0
+
+By Protesilaos Stavrou <info@protesilaos.com> on 2022-10-01
+
+
+Support for packages or faces
+=============================
+
+,* Reinstated support for 'centaur-tabs'.  I had removed it in commit
+  2235ce5 (done on 2022-08-02) for version 2.5.0 of the modus-themes.
+  At the time I wrote:
+
+      centaur-tabs has a bug where it cannot read the value of a face if it
+      uses the standard ':inherit' attribute.  I have sent a patch to fix it,
+      but have received no response since February:
+      <https://github.com/ema2159/centaur-tabs/pull/179>.
+
+      Relevant reports:
+
+      - <https://github.com/protesilaos/modus-themes/issues/30>
+      - <https://gitlab.com/protesilaos/modus-themes/-/issues/288>
+      - <https://github.com/protesilaos/modus-themes/issues/15>
+
+      I am happy to reinstate support for centaur-tabs as soon as the package
+      gets the maintenance it needs.
+
+  My patch/pull-request is now merged and the package is actively
+  maintained once again.  Hence the decision to bring back support for
+  it, as promised.
+
+,* Applied styles for the 'icon-button' face of Emacs 29.
+
+,* Styled the 'log-edit-headers-separator' face of Emacs 29 (it was
+  introduced upstream by a patch of mine).
+
+,* Made the 'gnus-summary-low-unread' face inherit from the 'italic'
+  face like the rest of that subgroup of faces.  This helps
+  differentiate it from the 'gnus-summary-high-unread' face.  Thanks
+  to Mark Simpson for pointing out the possibility of conflating those
+  two faces: <https://lists.sr.ht/~protesilaos/modus-themes/%3Cm2r0zszc2z.fsf@gmail.com%3E>.
+
+,* Covered the 'read-multiple-choice-face' by adding a noticeable
+  background colour to it.  The default attributes it has, which look
+  like other key bindings (bold and blue) plus an underline are
+  technically okay, though the context of this face is in the echo
+  area which is one line tall.  Moreover, the highlighted keys are
+  inlined with other text.  These make it difficult to spot the
+  highlights without some extra spacing.  I use the addition of a
+  background in Org's export dispatcher interface which also has some
+  unique requirements (the 'org-dispatcher-highlight' face).  The
+  principle is to have theme-wide consistency (e.g. "all key bindings
+  must look the same") EXCEPT when the specifics require a different
+  set of styles in the interest of usability.
+
+,* Extended the coverage of the 'auctex' package's faces to include the
+  'font-latex-underline-face'.  Thanks to Luis Miguel Castañeda for
+  reporting a typo I made which caused an error:
+  <https://lists.sr.ht/~protesilaos/modus-themes/%3C7h7d2oudpb.fsf@imaginarymagnitude.net%3E>
+
+,* Added support for 'crontab-mode'.  Thanks to Antonio Ruiz for the
+  patch: <https://lists.sr.ht/~protesilaos/modus-themes/patches/35080>.  It
+  is below the ~15 line threshold and thus requires no copyright
+  assignment to the Free Software Foundation.
+
+,* Extended support for the 'company' package's 'company-scrollbar-bg'
+  and 'company-scrollbar-fg' faces.
+
+,* Added support for the 'spell-fu' package.  Thanks to Antonio Ruiz
+  for the patch: <https://lists.sr.ht/~protesilaos/modus-themes/%3C87fshnq7uv.fsf%40purelymail.com%3E>.
+  Same as further above for Antonio's copyright status.
+
+,* Moved the 'selectrum-prescient' faces to the 'prescient' group, to
+  be consistent with changes in the respective upstream packages.
+  Thanks to okamsn for the contribution, which was done in pull
+  request 41 on the GitHub mirror: <https://github.com/protesilaos/modus-themes/pull/41>.
+  The user okamsn has assigned copyright assignment to the Free
+  Software Foundation, although this patch is within the allowed
+  limits.
+
+
+Change to 'fill-column-indicator'
+=================================
+
+Made the 'fill-column-indicator' face more noticeable.  It is what the
+'display-fill-column-indicator-mode' uses to draw a line on where the
+'fill-column' is.
+
+This change is in response to private messages I received as well as
+this, at parts impolite and toxic, thread that I refrained from
+participating in:
+<https://lists.gnu.org/archive/html/help-gnu-emacs/2022-08/msg00255.html>.
+
+[ I do not follow that mailing list, by the way.  All my projects have
+  multiple communication channels and I always reply in a timely
+  fashion.  Social media, fora about Emacs, generic mailing lists,
+  etc. are not among those channels.
+  <https://protesilaos.com/codelog/2022-07-24-report-issues-official-channels/>. ]
+
+The core idea is that the previous design was (1) considered
+"invisible" and (2) it prevented the customisation of the user option
+'display-fill-column-indicator-character'.
+
+I am addressing point 1, but point 2 puts us in an awkward spot as we
+would then not be allowed to use a background and a height value.  Not
+doing so produces a dashed line by default, with the dashes further
+apart the greater the line-spacing is (especially in, say, Org
+headings that can have a greater height than paragraph text).  It
+looks broken and I keep getting requests to fix what is not the
+themes' fault.  So no, the themes will remain opinionated in this
+regard by ignoring 'display-fill-column-indicator-character' through
+the styling they apply to make the line contiguous.
+
+For context, also read Emacs bug#57424 and please don't take my words
+in a private message out of context.  If I need to state my opinion in
+a public setting, I know how to do it.
+<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57424>.
+
+
+Refinement to modus-vivendi 'bg-diff-focus-removed' colour
+==========================================================
+
+Made the default removed diff background slightly more luminant.  The
+colour is seen in diff-mode, ediff, and the Magit focused diff hunk.
+
+When the user option 'modus-themes-diffs' is set to either 'bg-only' or
+'desaturated', this colour is used to highlight word-wise ("refined")
+changes.  The increased luminance lets it stand out more compared to the
+more subtle backdrop.
+
+Thanks to Kévin Le Gouguec for bringing this issue to my attention and
+for discussing it with me:
+<https://lists.sr.ht/~protesilaos/modus-themes/%3C87bks4i9tg.fsf@gmail.com%3E>
+
+
+Note about 'goto-address-mode'
+==============================
+
+Quote from the manual:
+
+    The built-in 'goto-address-mode' uses heuristics to identify URLs and
+    email addresses in the current buffer.  It then applies a face to them
+    to change their style.  Some packages, such as 'notmuch', use this
+    minor-mode automatically.
+
+    The faces are not declared with 'defface', meaning that it is better
+    that the theme does not modify them.  The user is thus encouraged to
+    consider including (or equivalent) this in their setup:
+
+        (setq goto-address-url-face 'link
+              goto-address-url-mouse-face 'highlight
+              goto-address-mail-face 'link
+              goto-address-mail-mouse-face 'highlight)
+
+    My personal preference is to set 'goto-address-mail-face' to nil, as
+    it otherwise adds too much visual noise to the buffer (email addresses
+    stand out more, due to the use of the uncommon '@' character but also
+    because they are often enclosed in angled brackets).
+
+
+Changes to the manual
+=====================
+
+,* Fixed a few typos and ensured that spelling using American English
+  as that is what emacs.git requires.
+
+,* Added the missing ':config' keywords from the example configuration
+  of the 'circadian' package.  Thanks to Koen van Greevenbroek for the
+  patch: <https://lists.sr.ht/~protesilaos/modus-themes/%3C8735cb6zm3.fsf%40posteo.net%3E>.
+#+end_src
+
 * 2.6.0
 :PROPERTIES:
 :CUSTOM_ID: h:fc108f65-3e0b-4e28-8030-86c797cb2b25
--- a/doc/modus-themes.info
+++ b/doc/modus-themes.info
@ -43,11 +43,11 @@ customization options for the ‘modus-operandi’ and ‘modus-vivendi’
 themes, and provides every other piece of information pertinent to them.

   The documentation furnished herein corresponds to stable version
-2.6.0, released on 2022-08-19.  Any reference to a newer feature which
+2.7.0, released on 2022-10-01.  Any reference to a newer feature which
 does not yet form part of the latest tagged commit, is explicitly marked
 as such.

-   Current development target is 2.7.0-dev.
+   Current development target is 2.8.0-dev.

   • Homepage: <https://protesilaos.com/emacs/modus-themes>.
   • Git repository: <https://git.sr.ht/~protesilaos/modus-themes>.
@ -4541,8 +4541,7 @@ have lots of extensions, so the “full support” may not be 100% true…
   • calendar and diary
   • calfw
   • calibredb
-   • centaur-tabs [ Part of 2.7.0-dev.  It was removed for a while as
-     the package was not maintained.  We are bringing back support.  ]
+   • centaur-tabs
   • cfrs
   • change-log and log-view (such as ‘vc-print-log’,
     ‘vc-print-root-log’)
@ -4563,7 +4562,7 @@ have lots of extensions, so the “full support” may not be 100% true…
   • counsel-css
   • cov
   • cperl-mode
-   • crontab-mode [ Part of 2.7.0-dev ]
+   • crontab-mode
   • css-mode
   • csv-mode
   • ctrlf
@ -4737,8 +4736,7 @@ have lots of extensions, so the “full support” may not be 100% true…
   • powerline
   • powerline-evil
   • prism (*note Note for prism.el: Note for prism.)
-   • presient [ Part of 2.7.0-dev.  The faces were originally in
-     ‘selectrum’.  ]
+   • presient
   • proced
   • prodigy
   • pulse
@ -4772,7 +4770,7 @@ have lots of extensions, so the “full support” may not be 100% true…
   • smerge
   • spaceline
   • speedbar
-   • spell-fu [ part of 2.7.0-dev ]
+   • spell-fu
   • stripes
   • suggest
   • switch-window
@ -5646,17 +5644,17 @@ minor-mode automatically.

   The faces are not declared with ‘defface’, meaning that it is better
 that the theme does not modify them.  The user is thus encouraged to
-consider including this in their setup:
+consider including (or equivalent) this in their setup:

     (setq goto-address-url-face 'link
           goto-address-url-mouse-face 'highlight
           goto-address-mail-face 'link
           goto-address-mail-mouse-face 'highlight)

-   My personal preference is to set ‘goto-address-mail-face’ to nil,
-because it otherwise adds too much visual noise to the buffer (email
-addresses stand out more, due to the use of the uncommon ‘@’ caharacter
-but also because they are often enclosed in angled brackets).
+   My personal preference is to set ‘goto-address-mail-face’ to nil, as
+it otherwise adds too much visual noise to the buffer (email addresses
+stand out more, due to the use of the uncommon ‘@’ character but also
+because they are often enclosed in angled brackets).


 File: modus-themes.info,  Node: Frequently Asked Questions,  Next: Contributing,  Prev: Notes on individual packages,  Up: Top
@ -6999,50 +6997,50 @@ Node: Custom hl-todo colors187400
 Node: Add support for solaire-mode188921
 Node: Face coverage191839
 Node: Supported packages192291
-Node: Indirectly covered packages199109
-Node: Notes on individual packages200237
-Node: Note on calendarel weekday and weekend colors201381
-Node: Note on git-gutter in Doom Emacs202529
-Node: Note on php-mode multiline comments204617
-Node: Note on underlines in compilation buffers205370
-Node: Note on inline Latex in Org buffers206207
-Node: Note on dimmerel206817
-Node: Note on display-fill-column-indicator-mode208302
-Node: Note on highlight-parenthesesel209700
-Node: Note on mmm-modeel background colors215750
-Node: Note for prism218065
-Node: Note for god-mode221221
-Node: Note on company-mode overlay pop-up222825
-Ref: Note on company-mode overlay pop-up-Footnote-1223515
-Ref: Note on company-mode overlay pop-up-Footnote-2223582
-Node: Note on ERC escaped color sequences223637
-Ref: Note on ERC escaped color sequences-Footnote-1225065
-Node: Note on powerline or spaceline225175
-Node: Note on SHR colors225589
-Node: Note on SHR fonts226013
-Node: Note on Ement colors and fonts226646
-Node: Note on Helm grep228145
-Node: Note on pdf-tools link hints229615
-Node: Note on the Notmuch logo232062
-Node: Note on goto-address-mode faces232600
-Node: Frequently Asked Questions233702
-Node: Is the contrast ratio about adjacent colors?234333
-Node: What does it mean to avoid exaggerations?235840
-Node: Why are colors mostly variants of blue magenta cyan?237669
-Node: What is the best setup for legibility?241975
-Node: Are these color schemes?244620
-Node: Port the Modus themes to other platforms?248340
-Node: Contributing251121
-Node: Sources of the themes251518
-Node: Issues you can help with252217
-Node: Patches require copyright assignment to the FSF253789
-Node: Acknowledgements256009
-Node: Other notes about the project259578
-Node: GNU Free Documentation License262576
-Node: Indices287953
-Node: Function index288132
-Node: Variable index289935
-Node: Concept index292222
+Node: Indirectly covered packages198866
+Node: Notes on individual packages199994
+Node: Note on calendarel weekday and weekend colors201138
+Node: Note on git-gutter in Doom Emacs202286
+Node: Note on php-mode multiline comments204374
+Node: Note on underlines in compilation buffers205127
+Node: Note on inline Latex in Org buffers205964
+Node: Note on dimmerel206574
+Node: Note on display-fill-column-indicator-mode208059
+Node: Note on highlight-parenthesesel209457
+Node: Note on mmm-modeel background colors215507
+Node: Note for prism217822
+Node: Note for god-mode220978
+Node: Note on company-mode overlay pop-up222582
+Ref: Note on company-mode overlay pop-up-Footnote-1223272
+Ref: Note on company-mode overlay pop-up-Footnote-2223339
+Node: Note on ERC escaped color sequences223394
+Ref: Note on ERC escaped color sequences-Footnote-1224822
+Node: Note on powerline or spaceline224932
+Node: Note on SHR colors225346
+Node: Note on SHR fonts225770
+Node: Note on Ement colors and fonts226403
+Node: Note on Helm grep227902
+Node: Note on pdf-tools link hints229372
+Node: Note on the Notmuch logo231819
+Node: Note on goto-address-mode faces232357
+Node: Frequently Asked Questions233469
+Node: Is the contrast ratio about adjacent colors?234100
+Node: What does it mean to avoid exaggerations?235607
+Node: Why are colors mostly variants of blue magenta cyan?237436
+Node: What is the best setup for legibility?241742
+Node: Are these color schemes?244387
+Node: Port the Modus themes to other platforms?248107
+Node: Contributing250888
+Node: Sources of the themes251285
+Node: Issues you can help with251984
+Node: Patches require copyright assignment to the FSF253556
+Node: Acknowledgements255776
+Node: Other notes about the project259345
+Node: GNU Free Documentation License262343
+Node: Indices287720
+Node: Function index287899
+Node: Variable index289702
+Node: Concept index291989

 End Tag Table

--- a/doc/modus-themes.org
+++ b/doc/modus-themes.org
@ -4,9 +4,9 @@
 #+language:              en
 #+options:               ':t toc:nil author:t email:t num:t
 #+startup:               content
-#+macro:                 stable-version 2.6.0
-#+macro:                 release-date 2022-08-19
-#+macro:                 development-version 2.7.0-dev
+#+macro:                 stable-version 2.7.0
+#+macro:                 release-date 2022-10-01
+#+macro:                 development-version 2.8.0-dev
 #+macro:                 file @@texinfo:@file{@@$1@@texinfo:}@@
 #+macro:                 space @@texinfo:@: @@
 #+macro:                 kbd @@texinfo:@kbd{@@$1@@texinfo:}@@
@ -4515,7 +4515,7 @@ have lots of extensions, so the "full support" may not be 100% true…
 + calendar and diary
 + calfw
 + calibredb
-+ centaur-tabs  [ Part of {{{development-version}}}.  It was removed for a while as the package was not maintained.  We are bringing back support.  ]
+ centaur-tabs
 + cfrs
 + change-log and log-view (such as ~vc-print-log~, ~vc-print-root-log~)
 + chart
@ -4535,7 +4535,7 @@ have lots of extensions, so the "full support" may not be 100% true…
 + counsel-css
 + cov
 + cperl-mode
-+ crontab-mode [ Part of {{{development-version}}} ]
+ crontab-mode
 + css-mode
 + csv-mode
 + ctrlf
@ -4708,7 +4708,7 @@ have lots of extensions, so the "full support" may not be 100% true…
 + powerline
 + powerline-evil
 + prism ([[#h:a94272e0-99da-4149-9e80-11a7e67a2cf2][Note for prism.el]])
-+ presient [ Part of {{{development-version}}}.  The faces were originally in =selectrum=. ]
+ presient
 + proced
 + prodigy
 + pulse
@ -4742,7 +4742,7 @@ have lots of extensions, so the "full support" may not be 100% true…
 + smerge
 + spaceline
 + speedbar
-+ spell-fu [ part of {{{development-version}}} ]
+ spell-fu
 + stripes
 + suggest
 + switch-window
--- a/modus-themes.el
+++ b/modus-themes.el
@ -6,7 +6,7 @@
 ;; Maintainer: Modus-Themes Development <~protesilaos/modus-themes@lists.sr.ht>
 ;; URL: https://git.sr.ht/~protesilaos/modus-themes
 ;; Mailing-List: https://lists.sr.ht/~protesilaos/modus-themes
-;; Version: 2.6.0
+;; Version: 2.7.0
 ;; Package-Requires: ((emacs "27.1"))
 ;; Keywords: faces, theme, accessibility

@ -109,7 +109,7 @@ cover the blue-cyan-magenta side of the spectrum."
  :prefix "modus-themes-"
  :tag "Modus Themes Faces")

-(defvar modus-themes--version "2.6.0"
+(defvar modus-themes--version "2.7.0"
  "Current version of the Modus themes.

 The version either is the last tagged release, such as '1.0.0',