Rename option to modus-themes-italic-constructs

The old 'modus-themes-slanted-constructs' was unnecessarily technical
with its use of the "slant" terminology.  That could potentially hinder
the dicoverability of this option.
This commit is contained in:
Protesilaos Stavrou 2021-07-05 09:02:36 +03:00
parent b271343c76
commit 52b0cd1a04
No known key found for this signature in database
GPG key ID: 99BD6459CD5CA3EA
4 changed files with 139 additions and 124 deletions

View file

@ -27,7 +27,7 @@ For some demo content, check:
:ensure
:init
;; Add all your customizations prior to loading the themes
(setq modus-themes-slanted-constructs t
(setq modus-themes-italic-constructs t
modus-themes-bold-constructs nil
modus-themes-region 'no-extend)
@ -52,7 +52,7 @@ possible values. Note that those settings are only for purposes of
demonstration:
```elisp
(setq modus-themes-slanted-constructs t
(setq modus-themes-italic-constructs t
modus-themes-bold-constructs nil
modus-themes-no-mixed-fonts nil
modus-themes-subtle-line-numbers nil

View file

@ -93,7 +93,7 @@ Customization Options
* Custom reload theme:: Toggle auto-reload of the theme when setting custom variables
* Success' color-code:: Toggle blue color for success or done states
* Bold constructs:: Toggle bold constructs in code
* Slanted constructs:: Toggle slanted constructs (italics) in code
* Italic constructs:: Toggle italic font constructs in code
* Syntax styles:: Choose the overall aesthetic of code syntax
* No mixed fonts:: Toggle mixing of font families
* Link styles:: Choose among several styles, with or without underline
@ -433,7 +433,7 @@ package configurations in their setup. We use this as an example:
:ensure ; omit this to use the built-in themes
:init
;; Add all your customizations prior to loading the themes
(setq modus-themes-slanted-constructs t
(setq modus-themes-italic-constructs t
modus-themes-bold-constructs nil
modus-themes-region 'no-extend)
@ -513,7 +513,7 @@ loading a theme (*note Enable and load::).
Below is a summary of what you will learn in the subsequent sections
of this manual.
(setq modus-themes-slanted-constructs t
(setq modus-themes-italic-constructs t
modus-themes-bold-constructs nil
modus-themes-no-mixed-fonts nil
modus-themes-subtle-line-numbers nil
@ -597,7 +597,7 @@ of this manual.
* Custom reload theme:: Toggle auto-reload of the theme when setting custom variables
* Success' color-code:: Toggle blue color for success or done states
* Bold constructs:: Toggle bold constructs in code
* Slanted constructs:: Toggle slanted constructs (italics) in code
* Italic constructs:: Toggle italic font constructs in code
* Syntax styles:: Choose the overall aesthetic of code syntax
* No mixed fonts:: Toggle mixing of font families
* Link styles:: Choose among several styles, with or without underline
@ -671,7 +671,7 @@ configured to conform with deuteranopia.
*note Option for diff buffer looks: Diffs.

File: modus-themes.info, Node: Bold constructs, Next: Slanted constructs, Prev: Success' color-code, Up: Customization Options
File: modus-themes.info, Node: Bold constructs, Next: Italic constructs, Prev: Success' color-code, Up: Customization Options
4.3 Option for more bold constructs
===================================
@ -692,26 +692,26 @@ syntax. It also affects certain mode line indicators and command-line
prompts.

File: modus-themes.info, Node: Slanted constructs, Next: Syntax styles, Prev: Bold constructs, Up: Customization Options
File: modus-themes.info, Node: Italic constructs, Next: Syntax styles, Prev: Bold constructs, Up: Customization Options
4.4 Option for more slanted constructs
======================================
4.4 Option for more italic constructs
=====================================
Symbol: modus-themes-slanted-constructs
Symbol: modus-themes-italic-constructs
Possible values:
1. nil (default)
2. t
The default is to not use slanted text (italics) unless it is
The default is to not use slanted text forms (italics) unless it is
absolutely necessary.
With a non-nil value (t) choose to render more faces in slanted
text. This typically affects documentation strings and code comments.
With a non-nil value (t) choose to render more faces in italics.
This typically affects documentation strings and code comments.

File: modus-themes.info, Node: Syntax styles, Next: No mixed fonts, Prev: Slanted constructs, Up: Customization Options
File: modus-themes.info, Node: Syntax styles, Next: No mixed fonts, Prev: Italic constructs, Up: Customization Options
4.5 Option for syntax highlighting
==================================
@ -4682,6 +4682,7 @@ B.2 Variable index
* modus-themes-headings: Heading styles. (line 6)
* modus-themes-hl-line: Line highlighting. (line 6)
* modus-themes-inhibit-reload: Custom reload theme. (line 6)
* modus-themes-italic-constructs: Italic constructs. (line 6)
* modus-themes-lang-checkers: Language checkers. (line 6)
* modus-themes-links: Link styles. (line 6)
* modus-themes-mail-citations: Mail citations. (line 6)
@ -4695,7 +4696,6 @@ B.2 Variable index
* modus-themes-prompts: Command prompts. (line 6)
* modus-themes-region: Active region. (line 6)
* modus-themes-scale-headings: Scaled headings. (line 6)
* modus-themes-slanted-constructs: Slanted constructs. (line 6)
* modus-themes-subtle-line-numbers: Line numbers. (line 6)
* modus-themes-success-deuteranopia: Success' color-code. (line 6)
* modus-themes-syntax: Syntax styles. (line 6)
@ -4763,98 +4763,98 @@ B.3 Concept index

Tag Table:
Node: Top860
Node: Overview6729
Node: How do the themes look like8272
Node: Learn about the latest changes8780
Node: Installation9162
Node: Install manually from source9643
Node: Install from the archives10468
Node: Install on GNU/Linux11245
Node: Debian 11 Bullseye11693
Node: GNU Guix12003
Node: Enable and load12286
Node: Sample configuration for use-package15275
Node: Differences between loading and enabling16644
Node: Customization Options18684
Node: Custom reload theme24857
Node: Success' color-code25444
Node: Bold constructs26381
Node: Slanted constructs26998
Node: Syntax styles27545
Node: No mixed fonts29183
Node: Link styles30278
Node: Command prompts31852
Node: Mode line33506
Node: Completion UIs37604
Node: Mail citations39475
Node: Fringes40328
Node: Language checkers40990
Node: Line highlighting42938
Node: Line numbers44451
Node: Matching parentheses45529
Node: Active region46419
Node: Diffs47637
Node: Org mode blocks49576
Node: Org agenda51454
Node: Org agenda habits57081
Node: Heading styles59047
Node: Scaled headings63277
Node: Scaled heading sizes63880
Node: UI typeface67136
Node: Headings' typeface67982
Node: Advanced customization (do-it-yourself)68606
Node: Per-theme customization settings (DIY)69969
Node: Case-by-case face specs using the themes' palette (DIY)71315
Node: Face specs at scale using the themes' palette (DIY)75779
Node: Remap face with local value (DIY)80596
Node: Cycle through arbitrary colors (DIY)83074
Node: Override colors (DIY)89640
Node: Override color saturation (DIY)94533
Node: Font configurations for Org and others (DIY)100286
Ref: Font configurations for Org and others (DIY)-Footnote-1102714
Node: Custom Org user faces (DIY)102901
Node: Update Org block delimiter fontification (DIY)106662
Node: Measure color contrast (DIY)108622
Node: Load theme depending on time of day (DIY)111416
Node: Backdrop for pdf-tools (DIY)112456
Node: A theme-agnostic hook for theme loading (DIY)115218
Node: Face coverage117608
Node: Supported packages118077
Node: Indirectly covered packages124850
Node: Notes on individual packages125404
Node: Note on inline Latex in Org buffers126228
Node: Note on dimmerel126788
Node: Note on display-fill-column-indicator-mode128273
Node: Note on mmm-modeel background colors129894
Node: Note for prism132273
Node: Note for god-mode135499
Node: Note on company-mode overlay pop-up137171
Ref: Note on company-mode overlay pop-up-Footnote-1137859
Ref: Note on company-mode overlay pop-up-Footnote-2137926
Node: Note on ERC escaped color sequences137981
Ref: Note on ERC escaped color sequences-Footnote-1139407
Node: Note on powerline or spaceline139517
Node: Note on SHR colors139929
Node: Note on EWW and Elfeed fonts (SHR fonts)140364
Node: Note on Helm grep141109
Node: Note on vc-annotate-background-mode142596
Node: Note on pdf-tools link hints143481
Node: Frequently Asked Questions (FAQ)145913
Node: Is the contrast ratio about adjacent colors?146487
Node: What does it mean to avoid exaggerations?148000
Node: Why are colors mostly variants of blue magenta cyan?149835
Node: What is the best setup for legibility?154182
Node: Contributing156789
Node: Sources of the themes157192
Node: Issues you can help with157930
Node: Patches require copyright assignment to the FSF159130
Node: Acknowledgements161425
Node: Meta163913
Node: GNU Free Documentation License165910
Node: Indices191262
Node: Function index191441
Node: Variable index192678
Node: Concept index194892
Node: Overview6723
Node: How do the themes look like8266
Node: Learn about the latest changes8774
Node: Installation9156
Node: Install manually from source9637
Node: Install from the archives10462
Node: Install on GNU/Linux11239
Node: Debian 11 Bullseye11687
Node: GNU Guix11997
Node: Enable and load12280
Node: Sample configuration for use-package15269
Node: Differences between loading and enabling16637
Node: Customization Options18677
Node: Custom reload theme24843
Node: Success' color-code25430
Node: Bold constructs26367
Node: Italic constructs26983
Node: Syntax styles27526
Node: No mixed fonts29163
Node: Link styles30258
Node: Command prompts31832
Node: Mode line33486
Node: Completion UIs37584
Node: Mail citations39455
Node: Fringes40308
Node: Language checkers40970
Node: Line highlighting42918
Node: Line numbers44431
Node: Matching parentheses45509
Node: Active region46399
Node: Diffs47617
Node: Org mode blocks49556
Node: Org agenda51434
Node: Org agenda habits57061
Node: Heading styles59027
Node: Scaled headings63257
Node: Scaled heading sizes63860
Node: UI typeface67116
Node: Headings' typeface67962
Node: Advanced customization (do-it-yourself)68586
Node: Per-theme customization settings (DIY)69949
Node: Case-by-case face specs using the themes' palette (DIY)71295
Node: Face specs at scale using the themes' palette (DIY)75759
Node: Remap face with local value (DIY)80576
Node: Cycle through arbitrary colors (DIY)83054
Node: Override colors (DIY)89620
Node: Override color saturation (DIY)94513
Node: Font configurations for Org and others (DIY)100266
Ref: Font configurations for Org and others (DIY)-Footnote-1102694
Node: Custom Org user faces (DIY)102881
Node: Update Org block delimiter fontification (DIY)106642
Node: Measure color contrast (DIY)108602
Node: Load theme depending on time of day (DIY)111396
Node: Backdrop for pdf-tools (DIY)112436
Node: A theme-agnostic hook for theme loading (DIY)115198
Node: Face coverage117588
Node: Supported packages118057
Node: Indirectly covered packages124830
Node: Notes on individual packages125384
Node: Note on inline Latex in Org buffers126208
Node: Note on dimmerel126768
Node: Note on display-fill-column-indicator-mode128253
Node: Note on mmm-modeel background colors129874
Node: Note for prism132253
Node: Note for god-mode135479
Node: Note on company-mode overlay pop-up137151
Ref: Note on company-mode overlay pop-up-Footnote-1137839
Ref: Note on company-mode overlay pop-up-Footnote-2137906
Node: Note on ERC escaped color sequences137961
Ref: Note on ERC escaped color sequences-Footnote-1139387
Node: Note on powerline or spaceline139497
Node: Note on SHR colors139909
Node: Note on EWW and Elfeed fonts (SHR fonts)140344
Node: Note on Helm grep141089
Node: Note on vc-annotate-background-mode142576
Node: Note on pdf-tools link hints143461
Node: Frequently Asked Questions (FAQ)145893
Node: Is the contrast ratio about adjacent colors?146467
Node: What does it mean to avoid exaggerations?147980
Node: Why are colors mostly variants of blue magenta cyan?149815
Node: What is the best setup for legibility?154162
Node: Contributing156769
Node: Sources of the themes157172
Node: Issues you can help with157910
Node: Patches require copyright assignment to the FSF159110
Node: Acknowledgements161405
Node: Meta163893
Node: GNU Free Documentation License165890
Node: Indices191242
Node: Function index191421
Node: Variable index192658
Node: Concept index194872

End Tag Table

View file

@ -297,7 +297,7 @@ package configurations in their setup. We use this as an example:
:ensure ; omit this to use the built-in themes
:init
;; Add all your customizations prior to loading the themes
(setq modus-themes-slanted-constructs t
(setq modus-themes-italic-constructs t
modus-themes-bold-constructs nil
modus-themes-region 'no-extend)
@ -378,7 +378,7 @@ Below is a summary of what you will learn in the subsequent sections of
this manual.
#+begin_src emacs-lisp
(setq modus-themes-slanted-constructs t
(setq modus-themes-italic-constructs t
modus-themes-bold-constructs nil
modus-themes-no-mixed-fonts nil
modus-themes-subtle-line-numbers nil
@ -534,26 +534,26 @@ weight. This concerns keywords and other important aspects of code
syntax. It also affects certain mode line indicators and command-line
prompts.
** Option for more slanted constructs
** Option for more italic constructs
:properties:
:alt_title: Slanted constructs
:description: Toggle slanted constructs (italics) in code
:alt_title: Italic constructs
:description: Toggle italic font constructs in code
:custom_id: h:977c900d-0d6d-4dbb-82d9-c2aae69543d6
:end:
#+vindex: modus-themes-slanted-constructs
#+vindex: modus-themes-italic-constructs
Symbol: ~modus-themes-slanted-constructs~
Symbol: ~modus-themes-italic-constructs~
Possible values:
1. ~nil~ (default)
2. ~t~
The default is to not use slanted text (italics) unless it is absolutely
necessary.
The default is to not use slanted text forms (italics) unless it is
absolutely necessary.
With a non-nil value (~t~) choose to render more faces in slanted text.
This typically affects documentation strings and code comments.
With a non-nil value (~t~) choose to render more faces in italics. This
typically affects documentation strings and code comments.
** Option for syntax highlighting
:properties:

View file

@ -5,7 +5,7 @@
;; Author: Protesilaos Stavrou <info@protesilaos.com>
;; URL: https://gitlab.com/protesilaos/modus-themes
;; Version: 1.4.0
;; Last-Modified: <2021-07-05 08:46:27 +0300>
;; Last-Modified: <2021-07-05 08:57:05 +0300>
;; Package-Requires: ((emacs "26.1"))
;; Keywords: faces, theme, accessibility
@ -37,7 +37,7 @@
;; are disabled by default (nil):
;;
;; modus-themes-inhibit-reload (boolean)
;; modus-themes-slanted-constructs (boolean)
;; modus-themes-italic-constructs (boolean)
;; modus-themes-bold-constructs (boolean)
;; modus-themes-variable-pitch-headings (boolean)
;; modus-themes-variable-pitch-ui (boolean)
@ -1467,7 +1467,7 @@ The actual styling of the face is done by `modus-themes-faces'."
(defface modus-themes-slant nil
"Generic face for applying a conditional slant (italics).
This behaves in accordance with `modus-themes-slanted-constructs'.
This behaves in accordance with `modus-themes-italic-constructs'.
The actual styling of the face is done by `modus-themes-faces'."
:group 'modus-theme-faces)
@ -1739,6 +1739,21 @@ For form, see `modus-themes-vivendi-colors'."
:initialize #'custom-initialize-default
:link '(info-link "(modus-themes) Slanted constructs"))
(define-obsolete-variable-alias
'modus-themes-slanted-constructs
'modus-themes-italic-constructs
"1.5.0")
(defcustom modus-themes-italic-constructs nil
"Use italic font forms in more code constructs."
:group 'modus-themes
:package-version '(modus-themes . "1.5.0")
:version "28.1"
:type 'boolean
:set #'modus-themes--set-option
:initialize #'custom-initialize-default
:link '(info-link "(modus-themes) Italic constructs"))
(defcustom modus-themes-bold-constructs nil
"Use bold text in more code constructs."
:group 'modus-themes
@ -2535,7 +2550,7 @@ Similarly, `italic' adds a slant to the font's forms (italic or
oblique forms, depending on the typeface).
Combinations of any of those properties can be expressed in a
list, as in those examples:
list, as in thosep examples:
(intense)
(bold intense)
@ -2867,7 +2882,7 @@ Those are stored in `modus-themes-faces' and
(defun modus-themes--slant ()
"Conditional use of italics for slant attribute."
(if modus-themes-slanted-constructs
(if modus-themes-italic-constructs
(list 'italic)
(list 'normal)))