firefox/tridactyl.tridactyl
1
0
Fork 0
mirror of https://github.com/tridactyl/tridactyl.git synced 2026-09-10 07:16:33 -04:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #5392 from Chic-Tweetz/fix-scrolling-jitter

Browse source 
Fix display dpi-dependent scroll jitter
This commit is contained in:
Oliver Blanthorn 2026-06-03 13:47:37 +00:00 committed by GitHub
parent 50aae4a898 37bf4cb3e5
commit 06457ee187
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/content/scrolling.ts
View file

@ -80,15 +80,17 @@ class ScrollingData {
this.startPos +
((this.endPos - this.startPos) * elapsed) / this.duration
if (this.startPos < this.endPos) {
const curPosRounded = Math.ceil(this.elem[this.scrollDirection])
// We need to ceil() because only highdpi screens have a decimal this.elem[this.pos]
pixelToScrollTo = Math.ceil(pixelToScrollTo)
// We *have* to make progress, otherwise we'll think the element can't be scrolled
if (pixelToScrollTo == Math.ceil(this.elem[this.scrollDirection]))
pixelToScrollTo += 1
if (pixelToScrollTo <= curPosRounded)
pixelToScrollTo = curPosRounded + 1
} else {
const curPosRounded = Math.floor(this.elem[this.scrollDirection])
pixelToScrollTo = Math.floor(pixelToScrollTo)
if (pixelToScrollTo == Math.floor(this.elem[this.scrollDirection]))
pixelToScrollTo -= 1
if (pixelToScrollTo >= curPosRounded)
pixelToScrollTo = curPosRounded - 1
}
return pixelToScrollTo
}
@ -96,7 +98,11 @@ class ScrollingData {
/** Updates the position of this.elem, returns true if the element has been scrolled, false otherwise. */
private scrollStep(): boolean {
const prevScrollPos: number = this.elem[this.scrollDirection]
this.elem[this.scrollDirection] = this.getStep()
const target = this.getStep()
this.elem[this.scrollDirection] = target
// Ensure endPos value is possible for display dpi
if (target === this.endPos)
this.endPos = this.elem[this.scrollDirection]
return prevScrollPos !== this.elem[this.scrollDirection]
}