firefox/tridactyl.tridactyl
1
0
Fork 0
mirror of https://github.com/tridactyl/tridactyl.git synced 2026-09-10 07:16:33 -04:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Extract queue management from cancelling

Browse source 
This stops us from having to cancel keyups twice
This commit is contained in:
Oliver Blanthorn 2026-07-05 11:35:07 +02:00
parent 8b2f71df6b
commit 6f848ea768
No known key found for this signature in database
GPG key ID: 2BB8C36BB504BFF3
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/content/controller_content.ts
View file

@ -61,7 +61,7 @@ class KeyCanceller {
this.cancelKey(ke, this.keyUp)
}
private cancelKey(ke: KeyboardEvent, kes: KeyboardEvent[]) {
private removeKey(ke: KeyboardEvent, kes: KeyboardEvent[]) {
const index = kes.findIndex(
ke2 =>
ke.altKey === ke2.altKey &&
@ -72,10 +72,15 @@ class KeyCanceller {
ke.shiftKey === ke2.shiftKey &&
ke.target === ke2.target,
)
if (index >= 0 && ke instanceof KeyboardEvent) {
if (index < 0) return false
kes.splice(index, 1)
return true
}
private cancelKey(ke: KeyboardEvent, kes: KeyboardEvent[]) {
if (this.removeKey(ke, kes) && ke instanceof KeyboardEvent) {
ke.preventDefault()
ke.stopImmediatePropagation()
kes.splice(index, 1)
}
}
}