firefox/tridactyl.tridactyl
1
0
Fork 0
mirror of https://github.com/tridactyl/tridactyl.git synced 2026-09-10 07:16:33 -04:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #5099 from leaty/bugfix/ui
Some checks failed
e2e / test (firefox, ubuntu) (push) Has been cancelled
Details
e2e / test (firefox, windows) (push) Has been cancelled
Details
e2e / test (firefoxesr, ubuntu) (push) Has been cancelled
Details
lint / lint (lint) (push) Has been cancelled
Details
lint / lint (mozilla) (push) Has been cancelled
Details
lint / lint (unit) (push) Has been cancelled
Details
Website / build (push) Has been cancelled
Details
Website / deploy (push) Has been cancelled
Details

Browse source 
Hide urlbar properly after firefox breaking change
This commit is contained in:
Oliver Blanthorn 2024-12-03 12:08:38 +00:00 committed by GitHub
parent f268f06452 547bf9a544
commit 8e4525a758
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 27 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/lib/css_util.ts
View file

@ -130,6 +130,27 @@ export const potentialRules = {
show: `max-height: 0; min-height: 0 !important;`,
},
},
// Hide urlbar after firefox breaking change caused it to show regardless of UI being hidden
urlbar: {
name: `:root:not([customizing]) #navigator-toolbox:not(:hover):not(:focus-within) #urlbar`,
options: {
hide: `min-height: 0 !important;
height: 0 !important;
overflow: hidden !important;`,
show: ``,
},
},
// Required for urlbar to keep working properly after being hidden by the above
// Otherwise, typing into the address field looks "invisible" due to low height
// being set directly on the element, and #urlbar having been forced (!important)
// to 0 height by us, meaning it can no longer compensate for this
urlbarcontainer: {
name: `:root:not([customizing]) #navigator-toolbox #urlbar-container`,
options: {
hide: `--urlbar-container-height: auto !important;`,
show: ``,
},
},
// This inherits transparency if we aren't careful
menubar: {
name: `#navigator-toolbox:not(:hover):not(:focus-within) #toolbar-menubar > *`,
@ -223,6 +244,8 @@ export const metaRules = {
navbarafter: "hide",
navbarnonaddonchildren: "show",
navbarnoheight: "hide",
urlbar: "hide",
urlbarcontainer: "hide",
},
always: {
navbarunfocused: "show",
@ -230,6 +253,8 @@ export const metaRules = {
navbarafter: "show",
navbarnonaddonchildren: "show",
navbarnoheight: "hide",
urlbar: "show",
urlbarcontainer: "show",
},
none: {
navbarunfocused: "show",
@ -237,6 +262,8 @@ export const metaRules = {
navbarafter: "hide",
navbarnonaddonchildren: "hide",
navbarnoheight: "show",
urlbar: "hide",
urlbarcontainer: "hide",
},
},
}