diff --git a/tests/assert.sh b/tests/assert.sh index 2b7d6c4..32a327f 100755 --- a/tests/assert.sh +++ b/tests/assert.sh @@ -17,12 +17,16 @@ # You should have received a copy of the GNU Lesser General Public License # along with this program. If not, see . +set -o nounset + export DISCOVERONLY=${DISCOVERONLY:-} export DEBUG=${DEBUG:-} export STOP=${STOP:-} export INVARIANT=${INVARIANT:-} export CONTINUE=${CONTINUE:-} +GREP=${GREP:-grep} + args="$(getopt -n "$0" -l \ verbose,help,stop,discover,invariant,continue vhxdic $*)" \ || exit -1 @@ -132,12 +136,12 @@ assert_raises() { _assert_with_grep() { local grep_modifier="$1" local output="$($2)" - local exitcode="$4" || 0 + local exitcode=0 shift 2 while [ $# != 0 ]; do - assert_raises "echo '$output' | $GREP $grep_modifier '$1'" $exitcode || return 1 - shift + assert_raises "echo '$output' | $GREP $grep_modifier '$1'" $exitcode || return 1 + shift done } diff --git a/tests/commands_test.sh b/tests/commands_test.sh index 793fb30..57e143f 100755 --- a/tests/commands_test.sh +++ b/tests/commands_test.sh @@ -73,13 +73,13 @@ ADDITIONAL USAGE assert_raises "$src fail" 1 -assert_contains "$src --suggest-reviewers" "Suggested code reviewers (based on git history)" 127 +assert_contains "$src --suggest-reviewers" "Suggested code reviewers (based on git history)" assert_raises "$src --suggest-reviewers" 0 -assert_contains "$src --detailed-git-stats" "Contribution stats" 127 +assert_contains "$src --detailed-git-stats" "Contribution stats" assert_raises "$src --detailed-git-stats" 0 -assert_contains "$src --commits-per-day" "Git commits per date" 127 +assert_contains "$src --commits-per-day" "Git commits per date" assert_raises "$src --commits-per-day" 0 assert_end