mirror of
https://gitea.com/gitea/tea.git
synced 2026-09-10 07:26:33 -04:00
9c12138d62
## Problem Follow-up to #1111, covering the issues side of the same hole: `tea issues create` accepts `--output` (it parses through the urfave/cli v3 ancestor-flag cascade — `issues` carries the flag via `AllDefaultFlags`, `create` never declares it) but the action never reads it. Without this fix, `tea issues create --output json | jq .url` feeds jq a markdown document. The default output is doubly hostile to consumers: glamour renders the details as markdown (with OSC 8 hyperlinks around the URL when piped), and a second bare `fmt.Println(issue.HTMLURL)` line follows it. ## What this changes - `task.CreateIssue` now returns the created `*gitea.Issue` instead of printing it. - `runIssuesCreate` switches on `--output`, mirroring the detail-command precedent and the merged create-PR behavior from #1111: `--output json` emits compact lean JSON; any other value (or no flag) falls through to the previous rendering, byte-identical to before. - Lean JSON shape: `index`, `title`, `url`, `state` — matching `createdPullJSON` in `cmd/pulls/create.go`, including its post-review compact encoding. - The interactive path is untouched — it only triggers when zero flags are set, so `--output` can never be active there. Example: ``` $ tea issues create --output json --title "bug: thing" | jq -r .url https://gitea.example.com/owner/repo/issues/42 ``` There is no agit-flow equivalent on issues, so no extra guard is needed — unlike the pulls side, every creation path produces an `*gitea.Issue`. --------- Co-authored-by: Danilo Sousa <code@danilosousa.net> Reviewed-on: https://gitea.com/gitea/tea/pulls/1114 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: ongolk <238961+ongolk@noreply.gitea.com>
96 lines
2.1 KiB
Go
96 lines
2.1 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package issues
|
|
|
|
import (
|
|
stdctx "context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
|
|
gitea "gitea.dev/sdk"
|
|
"github.com/urfave/cli/v3"
|
|
|
|
"gitea.dev/tea/cmd/flags"
|
|
"gitea.dev/tea/modules/context"
|
|
"gitea.dev/tea/modules/interact"
|
|
"gitea.dev/tea/modules/print"
|
|
"gitea.dev/tea/modules/task"
|
|
)
|
|
|
|
// CmdIssuesCreate represents a sub command of issues to create issue
|
|
var CmdIssuesCreate = cli.Command{
|
|
Name: "create",
|
|
Aliases: []string{"c"},
|
|
Usage: "Create an issue on repository",
|
|
Description: `Create an issue on repository`,
|
|
ArgsUsage: " ", // command does not accept arguments
|
|
Action: runIssuesCreate,
|
|
Flags: flags.IssuePRCreateFlags,
|
|
}
|
|
|
|
func runIssuesCreate(requestCtx stdctx.Context, cmd *cli.Command) error {
|
|
ctx, err := context.InitCommand(cmd)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if err := ctx.Ensure(context.CtxRequirement{RemoteRepo: true}); err != nil {
|
|
return err
|
|
}
|
|
|
|
if ctx.IsInteractiveMode() {
|
|
err := interact.CreateIssue(requestCtx, ctx.Login, ctx.Owner, ctx.Repo)
|
|
if err != nil && !interact.IsQuitting(err) {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
opts, err := flags.GetIssuePRCreateFlags(requestCtx, ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
issue, err := task.CreateIssue(requestCtx, ctx.Login,
|
|
ctx.Owner,
|
|
ctx.Repo,
|
|
*opts,
|
|
)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if ctx.IsSet("output") {
|
|
switch ctx.String("output") {
|
|
case "json":
|
|
return writeCreatedIssueAsJSON(ctx.Writer, issue)
|
|
}
|
|
}
|
|
|
|
print.IssueDetails(issue, nil)
|
|
|
|
fmt.Println(issue.HTMLURL)
|
|
|
|
return nil
|
|
}
|
|
|
|
// createdIssueJSON is the machine-readable representation of a freshly
|
|
// created issue, mirroring the create-PR equivalent in cmd/pulls/create.go
|
|
// (createdPullJSON).
|
|
type createdIssueJSON struct {
|
|
Index int64 `json:"index"`
|
|
Title string `json:"title"`
|
|
URL string `json:"url"`
|
|
State gitea.StateType `json:"state"`
|
|
}
|
|
|
|
func writeCreatedIssueAsJSON(w io.Writer, issue *gitea.Issue) error {
|
|
return json.NewEncoder(w).Encode(createdIssueJSON{
|
|
Index: issue.Index,
|
|
Title: issue.Title,
|
|
URL: issue.HTMLURL,
|
|
State: issue.State,
|
|
})
|
|
}
|