utils-code/jesseduffield.lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2026-09-10 15:46:26 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Session notes: first-drag-event driver fix (§21.32)

Browse source 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Stefan Haller 2026-06-20 21:06:05 +02:00
parent 6481ee615a
commit 0f99ba625a
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
focused-main-view-notes.md
View file

@ -3454,3 +3454,12 @@ Follow-up bugs the testing surfaced, all fixed (no tests, prototype):
between mouse-down and its drag, so no patch-identity needed). The old (buggy) behaviour came for free from
`selectDiffHunk` leaving a range anchor + gocui moving the cursor on drag; nothing handled the drag
explicitly before.
**Follow-on (`e74a33880`), a gocui driver bug the above exposed:** the *first* drag-movement event was
reported as `MouseRelease`, not `MouseLeft`+`ModMotion` — the tcell driver's `MAYBE_DRAGGING → DRAGGING`
transition (`tcell_driver.go`) set the state but left `mouseKey`/`mouseMod` at their defaults. gocui still
moved the cursor for it, but `onDragInFocusedView` didn't fire until the *second* moved-to line, so the
first line of a drag showed the stale hunk-end anchor (range from block end → cursor) before re-anchoring.
Symptom the user reported: "drag down one line → range from block end to here; one more line → snaps to
anchored-at-click, correct thereafter." Fix: mark that first movement as a drag like every later one. No
`MouseRelease` consumers exist (only `MouseLeft`/`ModMotion`), and it also tightens the patch explorer's
drag (its selection now grows from the first dragged line, not the second).