utils-code/jesseduffield.lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2026-09-15 10:06:26 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Dont log GitHub PR fetching errors to the Command log (#5600)

Browse source 
In the Command log we only want to see errors for user-initiated
actions, not from background activity.
This commit is contained in:
Stefan Haller 2026-05-10 15:49:43 +02:00 committed by GitHub
parent 18ddc9ca9c 58abf24862
commit 353e3a1e4a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
pkg/gui/controllers/helpers/refresh_helper.go
View file

@ -1,7 +1,6 @@
package helpers
import (
"fmt"
"strings"
"sync"
"time"
@ -831,9 +830,7 @@ func (self *RefreshHelper) refreshGithubPullRequests() {
return
}
if err := self.setGithubPullRequests(baseInfo); err != nil {
self.c.LogAction(fmt.Sprintf("Error fetching pull requests from GitHub: %s", err.Error()))
}
self.setGithubPullRequests(baseInfo)
}
type githubRemoteInfo struct {
@ -914,9 +911,7 @@ func (self *RefreshHelper) promptForBaseGithubRepo(githubRemotes []githubRemoteI
self.c.Log.Error(err)
}
if err := self.setGithubPullRequests(&info); err != nil {
self.c.LogAction(fmt.Sprintf("Error fetching pull requests from GitHub: %s", err.Error()))
}
self.setGithubPullRequests(&info)
return nil
})
},
@ -944,9 +939,9 @@ func (self *RefreshHelper) rebuildPullRequestsMap() {
)
}
func (self *RefreshHelper) setGithubPullRequests(baseInfo *githubRemoteInfo) error {
func (self *RefreshHelper) setGithubPullRequests(baseInfo *githubRemoteInfo) {
if len(self.c.Model().Branches) == 0 {
return nil
return
}
branches := lo.Filter(self.c.Model().Branches, func(branch *models.Branch, _ int) bool {
@ -958,7 +953,8 @@ func (self *RefreshHelper) setGithubPullRequests(baseInfo *githubRemoteInfo) err
prs, err := self.c.Git().GitHub.FetchRecentPRs(branchNames, &baseInfo.serviceInfo, baseInfo.authToken)
if err != nil {
return err
self.c.Log.Error("error fetching pull requests from GitHub: " + err.Error())
return
}
self.c.Model().PullRequests = prs
@ -969,8 +965,6 @@ func (self *RefreshHelper) setGithubPullRequests(baseInfo *githubRemoteInfo) err
self.c.PostRefreshUpdate(self.c.Contexts().Branches)
return nil
})
return nil
}
func (self *RefreshHelper) savePullRequestsToCache(prs []*models.GithubPullRequest) {