From 061665726eeca04e61fa478a1494aa704a40eb4f Mon Sep 17 00:00:00 2001 From: Stefan Haller Date: Tue, 16 Jun 2026 16:21:13 +0200 Subject: [PATCH 1/4] Fix Windows linter errors Apparently we don't check Windows-only code for linter errors on CI. --- pkg/logs/tail/logs_windows.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/logs/tail/logs_windows.go b/pkg/logs/tail/logs_windows.go index cf7aa395f..b116cb405 100644 --- a/pkg/logs/tail/logs_windows.go +++ b/pkg/logs/tail/logs_windows.go @@ -11,8 +11,8 @@ import ( ) func tailLogsForPlatform(logFilePath string, opts *humanlog.HandlerOptions) { - var lastModified int64 = 0 - var lastOffset int64 = 0 + var lastModified int64 + var lastOffset int64 for { stat, err := os.Stat(logFilePath) if err != nil { From df171722cb6b3595d7d6d44c35adbc6abfa1b585 Mon Sep 17 00:00:00 2001 From: Stefan Haller Date: Tue, 16 Jun 2026 16:21:13 +0200 Subject: [PATCH 2/4] Make .go files have LF line endings on Windows Since gofumpt expects and emits LF even on Windows, this makes it easier for agents to gofumpt their files. --- .gitattributes | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitattributes b/.gitattributes index 8143bb75f..ec9895f39 100644 --- a/.gitattributes +++ b/.gitattributes @@ -1,3 +1,3 @@ -*.go text +*.go text eol=lf *.md text eol=lf *.json text eol=lf From fcce4de6fcbbcd1da8ecef925702c2c480454df0 Mon Sep 17 00:00:00 2001 From: Stefan Haller Date: Tue, 16 Jun 2026 13:25:45 +0200 Subject: [PATCH 3/4] Allow running check_script.sh when there are uncommitted changes --- scripts/check_commit.sh | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/scripts/check_commit.sh b/scripts/check_commit.sh index 9cc5e5c7b..37557462e 100755 --- a/scripts/check_commit.sh +++ b/scripts/check_commit.sh @@ -5,15 +5,13 @@ set -e -git diff --quiet || { - echo "Error: there are unstaged changes. Please stage or stash them before running this script." - exit 1 -} - just test just lint + +status_before_generate=$(git status --porcelain=v1) just generate -git diff --quiet || { +status_after_generate=$(git status --porcelain=v1) +if [[ "$status_after_generate" != "$status_before_generate" ]]; then echo "Error: auto-generated files not up to date." exit 1 -} +fi From 643f169be2baad95604a4d8b23fa0c2a9dd4db1d Mon Sep 17 00:00:00 2001 From: Stefan Haller Date: Tue, 16 Jun 2026 13:38:49 +0200 Subject: [PATCH 4/4] Don't include integration tests in "just test" on Windows This allows running "just check" on Windows, it just doesn't check quite as much. --- justfile | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/justfile b/justfile index 36e8ee3d6..e7f9fcdc5 100644 --- a/justfile +++ b/justfile @@ -22,8 +22,13 @@ unit-test: go test ./... -short # Run both unit tests and integration tests. +[unix] test: unit-test e2e-all +# On Windows, integration tests are not supported right now +[windows] +test: unit-test + # Generate all our auto-generated files (test list, cheatsheets, json schema, maybe other things in the future) generate: go generate ./...