diff --git a/AGENTS.md b/AGENTS.md index 50b808fb4..7bed30c6c 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -63,6 +63,9 @@ while still being meaningful and self-contained. preceding commit, by staging hunks or resetting and recommitting in order. - **Do not use conventional commits** (no `feat:`/`fix:`/`chore:` prefixes). Match the plain English imperative style of the existing history. +- **Wrap message body to 72 characters**. The subject is allowed to go up to 80 + characters, or even a little more if needed to convey a good single-line + summary; the body should be wrapped at 72 exactly, no more, no less. ## Iterate with `fixup!` commits diff --git a/pkg/tasks/tasks.go b/pkg/tasks/tasks.go index c2964a8b9..f534d01b4 100644 --- a/pkg/tasks/tasks.go +++ b/pkg/tasks/tasks.go @@ -248,8 +248,26 @@ func (self *ViewBufferManager) NewCmdTask(start func() (*exec.Cmd, io.Reader), p } } + // Go's select picks randomly among ready cases, so once opts.Stop is + // closed the selects below could still service a ready data channel + // instead of bailing. Check stop explicitly first to give it priority: + // a task that's been stopped (it's being replaced by a newer one) must + // not touch the view here — beforeStart clears it and the prefix gets + // written, clobbering what the incoming task is about to render. + stopped := func() bool { + select { + case <-opts.Stop: + return true + default: + return false + } + } + outer: for { + if stopped() { + break outer + } select { case <-opts.Stop: break outer @@ -260,6 +278,10 @@ func (self *ViewBufferManager) NewCmdTask(start func() (*exec.Cmd, io.Reader), p } } for i := 0; linesToRead.Total == -1 || i < linesToRead.Total; i++ { + if stopped() { + callThen() + break outer + } var ok bool var line []byte select {