From 78dd678ce518910dcf486a8cb2396a389cc60228 Mon Sep 17 00:00:00 2001 From: Stefan Haller Date: Tue, 7 Jul 2026 17:20:38 +0200 Subject: [PATCH] Drop the now-redundant manual re-render in tag push Pushing a tag triggers no refresh, so it used to redraw the tags view by hand to remove the "Pushing" inline status. WithInlineStatus now always re-renders after clearing the operation, so this is redundant. Co-Authored-By: Claude Opus 4.8 (1M context) --- pkg/gui/controllers/tags_controller.go | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/pkg/gui/controllers/tags_controller.go b/pkg/gui/controllers/tags_controller.go index 3cb5e0450..fe2c4e80f 100644 --- a/pkg/gui/controllers/tags_controller.go +++ b/pkg/gui/controllers/tags_controller.go @@ -332,15 +332,7 @@ func (self *TagsController) push(tag *models.Tag) error { HandleConfirm: func(response string) error { return self.c.WithInlineStatus(tag, types.ItemOperationPushing, context.TAGS_CONTEXT_KEY, func(task gocui.Task) error { self.c.LogAction(self.c.Tr.Actions.PushTag) - err := self.c.Git().Tag.Push(task, response, tag.Name) - - // Render again to remove the inline status: - self.c.OnUIThread(func() error { - self.c.Contexts().Tags.HandleRender() - return nil - }) - - return err + return self.c.Git().Tag.Push(task, response, tag.Name) }) }, })