From 8eb0b0f4caee4044acd278eb18c901bc7312dfe3 Mon Sep 17 00:00:00 2001
From: Jesse Duffield <jessedduffield@gmail.com>
Date: Tue, 25 Feb 2020 22:08:03 +1100
Subject: [PATCH] do not close over variables in a function

---
 pkg/gui/rebase_options_panel.go | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/pkg/gui/rebase_options_panel.go b/pkg/gui/rebase_options_panel.go
index f1e87b235..2187cef58 100644
--- a/pkg/gui/rebase_options_panel.go
+++ b/pkg/gui/rebase_options_panel.go
@@ -16,10 +16,12 @@ func (gui *Gui) handleCreateRebaseOptionsMenu(g *gocui.Gui, v *gocui.View) error
 
 	menuItems := make([]*menuItem, len(options))
 	for i, option := range options {
+		// note to self. Never, EVER, close over loop variables in a function
+		innerOption := option
 		menuItems[i] = &menuItem{
-			displayString: option,
+			displayString: innerOption,
 			onPress: func() error {
-				return gui.genericMergeCommand(option)
+				return gui.genericMergeCommand(innerOption)
 			},
 		}
 	}