utils-code/jesseduffield.lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2026-09-10 07:36:27 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Block input and batch UI updates when switching repos

Browse source 
On startup we don't want to block input during the initial refresh (it
should be possible to press, say, `4` to jump to the commits panel right
after startup without a delay), and we also want panels to show their
contents as soon as possible; it doesn't matter so much that it's not in
sync, we go from empty to populated here. However, when switching repos
it can be confusing that some panels that are slow to update still show
the old repo's data while others already show the new one's data, so
update the UI only when everything is ready, and also block input to
prevent accidentally trying to act on the old, stale data.
This commit is contained in:
Stefan Haller 2026-07-21 20:38:41 +02:00
parent fc975f32a8
commit 975da9b8a9
1 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
pkg/gui/gui.go
View file

@ -1103,12 +1103,31 @@ func (gui *Gui) runSubprocess(cmdObj *oscommands.CmdObj) error {
return err
}
var isFirstRefreshAfterStartup = true
func (gui *Gui) loadNewRepo() error {
if err := gui.updateRecentRepoList(); err != nil {
return err
}
gui.c.Refresh(types.RefreshOptions{DontBlockRepoSwitch: true})
// On startup we don't want to block input during the initial refresh (it
// should be possible to press, say, `4` to jump to the commits panel right
// after startup without a delay), and we also want panels to show their
// contents as soon as possible; it doesn't matter so much that it's not in
// sync, we go from empty to populated here. However, when switching repos
// it can be confusing that some panels that are slow to update still show
// the old repo's data while others already show the new one's data, so
// update the UI only when everything is ready, and also block input to
// prevent accidentally trying to act on the old, stale data.
options := types.RefreshOptions{DontBlockRepoSwitch: true}
refresh := gui.c.Refresh
if isFirstRefreshAfterStartup {
isFirstRefreshAfterStartup = false
} else {
options.BatchUIUpdates = true
refresh = gui.c.RefreshBlockingInput
}
refresh(options)
if err := gui.os.UpdateWindowTitle(); err != nil {
return err