utils-code/jesseduffield.lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2026-09-10 07:36:27 -04:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Also verify stage-all can unstage a dirty submodule

Browse source 
Before the staging decision was unified, the stage (space) and stage-all
(a) keybindings each made their own decision, so a fix to one wouldn't
reach the other. Extend the test to drive the submodule through stage-all
as well, guarding against that asymmetry coming back.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Stefan Haller 2026-06-02 12:09:41 +02:00
parent 3f0a7512f8
commit c46c874442
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
pkg/integration/tests/submodule/stage.go
View file

@ -6,7 +6,7 @@ import (
)
var Stage = NewIntegrationTest(NewIntegrationTestArgs{
Description: "Stage and unstage a submodule that has both a new commit and dirty content. The new commit can be staged, but the dirty content can't, so unstaging must still work.",
Description: "Stage and unstage a submodule that has both a new commit and dirty content. The new commit can be staged, but the dirty content can't, so unstaging must still work; this must hold for both the stage (space) and stage-all (a) keybindings.",
ExtraCmdArgs: []string{},
Skip: false,
SetupConfig: func(config *config.AppConfig) {
@ -39,6 +39,18 @@ var Stage = NewIntegrationTest(NewIntegrationTestArgs{
// Pressing again must unstage the submodule, taking us back to
// " M" rather than trying (and failing) to stage the dirty content.
PressPrimaryAction().
Lines(
Equals(" M my_submodule_path (submodule)").IsSelected(),
).
// The same has to hold for the stage-all keybinding, which shares
// the same decision logic: it stages the new commit...
Press(keys.Files.ToggleStagedAll).
Lines(
Equals("MM my_submodule_path (submodule)").IsSelected(),
).
// ...and then unstages it again rather than getting stuck on the
// dirty content.
Press(keys.Files.ToggleStagedAll).
Lines(
Equals(" M my_submodule_path (submodule)").IsSelected(),
)