From f45ecbc19ac8c5dd4772ebe87f9c06f533e4feba Mon Sep 17 00:00:00 2001 From: Stefan Haller Date: Wed, 29 May 2024 11:11:51 +0200 Subject: [PATCH] Fix out-of-date comment The behavior described in the comment is no longer what we do, it was changed in ae66f720f5; we now always reuse the state. --- pkg/gui/gui.go | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/pkg/gui/gui.go b/pkg/gui/gui.go index caa385c3b..0c0f36370 100644 --- a/pkg/gui/gui.go +++ b/pkg/gui/gui.go @@ -342,15 +342,8 @@ func (gui *Gui) onNewRepo(startArgs appTypes.StartArgs, contextKey types.Context return nil } -// resetState determines if we pull the repo state from our repo state map or -// just re-initialize it. For now we're only re-using state when we're going -// in and out of submodules, for the sake of having the cursor back on the submodule -// when we return. -// -// I tried out always reverting to the repo's original state but found that in fact -// it gets a bit confusing to land back in the status panel when visiting a repo -// you've already switched from. There's no doubt some easy way to make the UX -// optimal for all cases but I'm too lazy to think about what that is right now +// resetState reuses the repo state from our repo state map, if the repo was +// open before; otherwise it creates a new one. func (gui *Gui) resetState(startArgs appTypes.StartArgs) types.Context { worktreePath := gui.git.RepoPaths.WorktreePath()