mirror of
https://github.com/jesseduffield/lazygit.git
synced 2026-09-13 00:56:25 -04:00
CheckMergeOrRebaseWithRefreshOptions refreshes after a merge/rebase step, and until now always via the UI-thread Refresh. Most of its callers are on a worker (the WithWaitingStatus/WithInlineStatus merge, squash-merge, rebase, pull, amend, drop, and patch-move handlers), so that refresh reads the commits scope off the UI thread — the race the previous commit addresses for everything else. Split it: the default is for worker callers and refreshes via RefreshFromWorker; a new CheckMergeOrRebaseWithRefreshOptionsFromUIThread is for the handlers that run the step synchronously on the UI thread (WithWaitingStatusSync, kept sync so rapid key presses batch): move up/down, revert, squash-fixups, cherry-pick paste, and patch-discard. The two share a private impl carrying which thread the caller is on, and the auto-skip recursion (genericMergeCommandImpl for an empty commit) threads it through so the follow-up step refreshes on the same thread. The merge-and-commit refresh in SquashMergeCommitted, also on a worker, moves to RefreshFromWorker to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
167 lines
4.6 KiB
Go
167 lines
4.6 KiB
Go
package helpers
|
|
|
|
import (
|
|
"strconv"
|
|
|
|
"github.com/jesseduffield/lazygit/pkg/commands/models"
|
|
"github.com/jesseduffield/lazygit/pkg/gui/modes/cherrypicking"
|
|
"github.com/jesseduffield/lazygit/pkg/gui/types"
|
|
"github.com/jesseduffield/lazygit/pkg/utils"
|
|
"github.com/samber/lo"
|
|
)
|
|
|
|
type CherryPickHelper struct {
|
|
c *HelperCommon
|
|
|
|
rebaseHelper *MergeAndRebaseHelper
|
|
}
|
|
|
|
// I'm using the analogy of copy+paste in the terminology here because it's intuitively what's going on,
|
|
// even if in truth we're running git cherry-pick
|
|
|
|
func NewCherryPickHelper(
|
|
c *HelperCommon,
|
|
rebaseHelper *MergeAndRebaseHelper,
|
|
) *CherryPickHelper {
|
|
return &CherryPickHelper{
|
|
c: c,
|
|
rebaseHelper: rebaseHelper,
|
|
}
|
|
}
|
|
|
|
func (self *CherryPickHelper) getData() *cherrypicking.CherryPicking {
|
|
return self.c.Modes().CherryPicking
|
|
}
|
|
|
|
func (self *CherryPickHelper) CopyRange(commitsList []*models.Commit, context types.IListContext) error {
|
|
startIdx, endIdx := context.GetList().GetSelectionRange()
|
|
|
|
if err := self.resetIfNecessary(context); err != nil {
|
|
return err
|
|
}
|
|
|
|
// After a paste the buffer is hidden but not cleared, so the user
|
|
// thinks they're starting fresh. Clear it before adding so the new
|
|
// copy replaces the old one.
|
|
if self.getData().DidPaste {
|
|
self.getData().CherryPickedCommits = nil
|
|
self.getData().DidPaste = false
|
|
}
|
|
|
|
commitSet := self.getData().SelectedHashSet()
|
|
|
|
allCommitsCopied := lo.EveryBy(commitsList[startIdx:endIdx+1], func(commit *models.Commit) bool {
|
|
return commitSet.Includes(commit.Hash())
|
|
})
|
|
|
|
// if all selected commits are already copied, we'll uncopy them
|
|
if allCommitsCopied {
|
|
for index := startIdx; index <= endIdx; index++ {
|
|
commit := commitsList[index]
|
|
self.getData().Remove(commit, commitsList)
|
|
}
|
|
} else {
|
|
for index := startIdx; index <= endIdx; index++ {
|
|
commit := commitsList[index]
|
|
self.getData().Add(commit, commitsList)
|
|
}
|
|
}
|
|
|
|
self.rerender()
|
|
return nil
|
|
}
|
|
|
|
// HandlePasteCommits begins a cherry-pick rebase with the commits the user has copied.
|
|
// Only to be called from the branch commits controller
|
|
func (self *CherryPickHelper) Paste() error {
|
|
self.c.Confirm(types.ConfirmOpts{
|
|
Title: self.c.Tr.CherryPick,
|
|
Prompt: utils.ResolvePlaceholderString(
|
|
self.c.Tr.SureCherryPick,
|
|
map[string]string{
|
|
"numCommits": strconv.Itoa(len(self.getData().CherryPickedCommits)),
|
|
}),
|
|
HandleConfirm: func() error {
|
|
return self.c.WithWaitingStatusSync(self.c.Tr.CherryPickingStatus, func() error {
|
|
mustStash := IsWorkingTreeDirtyExceptSubmodules(self.c.Model().Files, self.c.Model().Submodules)
|
|
|
|
self.c.LogAction(self.c.Tr.Actions.CherryPick)
|
|
|
|
if mustStash {
|
|
if err := self.c.Git().Stash.Push(self.c.Tr.AutoStashForCherryPicking); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
cherryPickedCommits := self.getData().CherryPickedCommits
|
|
result := self.c.Git().Rebase.CherryPickCommits(cherryPickedCommits)
|
|
err := self.rebaseHelper.CheckMergeOrRebaseWithRefreshOptionsFromUIThread(result, types.RefreshOptions{Mode: types.SYNC})
|
|
if err != nil {
|
|
return result
|
|
}
|
|
|
|
// If we're in the cherry-picking state at this point, it must
|
|
// be because there were conflicts. Don't clear the copied
|
|
// commits in this case, since we might want to abort and try
|
|
// pasting them again.
|
|
isInCherryPick, result := self.c.Git().Status.IsInCherryPick()
|
|
if result != nil {
|
|
return result
|
|
}
|
|
if !isInCherryPick {
|
|
self.getData().DidPaste = true
|
|
self.rerender()
|
|
|
|
if mustStash {
|
|
if err := self.c.Git().Stash.Pop(0); err != nil {
|
|
return err
|
|
}
|
|
self.c.Refresh(types.RefreshOptions{
|
|
Scope: []types.RefreshableView{types.STASH, types.FILES},
|
|
})
|
|
}
|
|
}
|
|
|
|
return nil
|
|
})
|
|
},
|
|
})
|
|
|
|
return nil
|
|
}
|
|
|
|
func (self *CherryPickHelper) CanPaste() bool {
|
|
return self.getData().CanPaste()
|
|
}
|
|
|
|
func (self *CherryPickHelper) Reset() error {
|
|
self.getData().ContextKey = ""
|
|
self.getData().CherryPickedCommits = nil
|
|
|
|
self.rerender()
|
|
return nil
|
|
}
|
|
|
|
// you can only copy from one context at a time, because the order and position of commits matter
|
|
func (self *CherryPickHelper) resetIfNecessary(context types.Context) error {
|
|
oldContextKey := types.ContextKey(self.getData().ContextKey)
|
|
|
|
if oldContextKey != context.GetKey() {
|
|
// need to reset the cherry picking mode
|
|
self.getData().ContextKey = string(context.GetKey())
|
|
self.getData().CherryPickedCommits = make([]*models.Commit, 0)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (self *CherryPickHelper) rerender() {
|
|
for _, context := range []types.Context{
|
|
self.c.Contexts().LocalCommits,
|
|
self.c.Contexts().ReflogCommits,
|
|
self.c.Contexts().SubCommits,
|
|
} {
|
|
self.c.PostRefreshUpdate(context)
|
|
}
|
|
}
|