jesseduffield.lazygit/pkg/gui
Stefan Haller 95940ee01e Ignore commit prefixes with an empty pattern
Before we changed the commitPrefix config to a list in #4261, we had this bug
where the defaults section in Config.md would erroneously list the default for
commitPrefix as

  git:
    commitPrefix:
      pattern: ""
      replace: ""

This was not correct, commitPrefix was a pointer, and the default for that was
nil, which is not the same.

Now, some people copied and pasted the entire defaults section into their config
files, setting the commitPrefix to an empty pattern (which is not the same as
not setting it at all). And this caused the branch name to be filled in to the
subject field for every commit; see for example
https://github.com/jesseduffield/lazygit/discussions/3632.

New users copying the defaults section into their config file in the current
version no longer have this problem because now that commitPrefix is a list, it
is no longer included in the defaults section. However, the migration that we
added in #4261 would happily carry over those empty strings into a list entry,
so people migrating from an older version still have the broken config in their
config files.

To work around the issue, ignore commit prefix settings whose pattern is an
empty string. I can't imagine a valid reason why people would actually want to
set the pattern to an empty string, so I assume this only comes from the broken
defaults problem described above.
2025-03-12 08:15:36 +01:00
..
context Implement reboot-resistant commit message persistence 2025-02-07 09:28:27 +01:00
controllers Ignore commit prefixes with an empty pattern 2025-03-12 08:15:36 +01:00
filetree Update to go 1.24 2025-03-08 14:53:54 -05:00
keybindings Move labelByKey to config package 2025-02-21 13:20:33 +01:00
mergeconflicts Remove redundant variable dedeclarations 2024-05-19 16:38:21 +10:00
modes Allow pasting commits more than once 2024-10-13 16:55:54 +02:00
patch_exploring Add a tabWidth parameter to WrapViewLinesToWidth to match gocui 2025-02-20 09:13:56 +01:00
popup Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
presentation Update to go 1.24 2025-03-08 14:53:54 -05:00
services/custom_commands Add commandMenu property to custom commands 2025-02-28 10:11:30 +01:00
status Clean up error handling of WithWaitingStatus and WithWaitingStatusSync 2024-04-18 10:10:30 +02:00
style Add function to render a hyperlink 2024-08-24 10:36:01 +02:00
types Standardise on 'screen mode' name 2025-01-11 14:25:48 +11:00
background.go Fix flicker when showing the status of a background fetch 2025-01-30 08:49:58 +01:00
command_log_panel.go Change direct access to Common.UserConfig to a getter 2024-08-18 10:24:52 +02:00
context.go Remove return value of IContextMgr.Push/Pop et. al. 2024-09-06 08:45:48 +02:00
context_config.go move some methods 2023-04-30 13:19:53 +10:00
controllers.go Fix mouse wheel scrolling of custom patch view 2024-12-01 10:48:27 +01:00
dummies.go Optimize number of early calls to GetRepoPaths 2024-07-06 12:09:48 -07:00
editors.go Add emacs-keybinds for word navigation 2023-08-15 12:22:17 +02:00
extras_panel.go Remove return value of IContextMgr.Push/Pop et. al. 2024-09-06 08:45:48 +02:00
global_handlers.go Use our new hyperlink support in confirmations 2024-08-24 10:36:01 +02:00
gui.go Set view titles in configureViewProperties rather than createAllViews 2025-03-06 08:24:03 +01:00
gui_common.go Get rid of error return value of PostRefreshUpdate and a few related ones 2024-10-13 16:55:54 +02:00
gui_driver.go Fix clicking multiple times in an integration test 2024-10-18 10:06:52 +02:00
information_panel.go Bump gocui and adapt lazygit code 2024-12-01 10:40:08 +01:00
keybindings.go Disable global keybinds while popups are active 2025-02-23 08:44:48 +01:00
layout.go Set tab titles after reloading user config 2025-03-06 08:24:03 +01:00
main_panels.go Remove return value of RenderToMainViews and some related functions 2024-09-06 08:45:48 +02:00
menu_panel.go Get rid of error return value of PostRefreshUpdate and a few related ones 2024-10-13 16:55:54 +02:00
options_map.go Fix layout of options view for non-english languages 2025-03-06 08:19:35 +01:00
pty.go Bump gocui and adapt lazygit code 2024-12-01 10:40:08 +01:00
pty_windows.go Format code to pass lint 2021-09-16 21:38:43 +08:00
recent_repos_panel.go Remove unused field gui.IsNewRepo 2024-12-01 10:44:26 +01:00
tasks_adapter.go Change NewRenderStringWith{out}ScrollTask to reuse the task key of the existing task 2024-10-18 22:46:47 +02:00
test_mode.go Don't wait in integration tests when running in headless mode 2024-06-05 14:44:02 +02:00
view_helpers.go Bump gocui and adapt lazygit code 2024-12-01 10:40:08 +01:00
views.go Set tab titles after reloading user config 2025-03-06 08:24:03 +01:00