Stefan Haller 0a92529b14 Prevent stale index.lock files from diffs rendered through a pty on Windows ... At the end of a diff against the worktree, git re-reads and refreshes the index and writes it back if it found stale stat information (diff.autoRefreshIndex, on by default). It holds index.lock for the whole refresh; GIT_OPTIONAL_LOCKS does not cover this lock, and the window scales with the size of the repository (~150ms for a 6k-file repository with a warm stat cache). On Windows, a pty task that is stopped because the user moved on terminates its git process at an arbitrary point: tearing down the pseudoconsole delivers CTRL_CLOSE_EVENT, which git leaves to the default handler, which simply calls ExitProcess. If that lands inside the refresh, a stale index.lock is left behind and the next git command chokes on it. This is the same problem that 98801da106 fixed by no longer killing git processes; the ConPTY support added in 0.63 reintroduced it through the close event. Disable the automatic refresh for pty-rendered commands. They can afford it: the refresh only persists refreshed stat information, and lazygit's foreground git status refreshes -- which never run in a pty and are never killed -- already write that back on every user action and on terminal focus-in. The cost is that while the on-disk stat cache is stale, an external differ is invoked even for files whose stat information changed but whose content didn't, showing them as empty diffs; this heals with the next foreground refresh, which also re-renders the view. Unix keeps the refresh: a stopped pty child gets SIGTERM there, and git's signal handlers remove its lock files, so the lock window is harmless. The rawGit renderer keeps it too: its tasks don't run in a pty and are never killed on Windows -- they either run to completion or die on a broken pipe mid-output, before the refresh begins. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>		2026-08-04 06:53:53 +02:00
..
app	Move dragged commits in one rebase	2026-07-31 08:37:28 +02:00
cheatsheet	Render every key for a binding in the cheatsheet	2026-05-25 15:18:18 +02:00
commands	Carry aggregate check state with GitHub pull requests	2026-07-31 09:01:44 +02:00
common	Move NewDummyCommon to pkg/common	2025-05-06 09:43:26 +02:00
config	Move Github PR cache out of state.yml into a separate file	2026-08-02 19:09:22 +02:00
constants	Adapt links	2026-07-31 08:42:51 +02:00
env	Support bare worktrees where worktree does not have its own .git file	2023-08-07 22:40:53 +10:00
fakes	Modernize all codes	2025-11-15 10:46:23 +01:00
gocui	Exclude more commit trailers from auto-wrapping	2026-08-02 19:22:34 +02:00
gui	Prevent stale index.lock files from diffs rendered through a pty on Windows	2026-08-04 06:53:53 +02:00
i18n	Show a Github PR's combined checks state in branches list and main view	2026-08-02 13:06:21 +02:00
integration	Rework the custom pager config (rename to diff renderer)	2026-07-31 08:42:51 +02:00
jsonschema	Fold legacy quit-alt1 into the multi-key quit binding	2026-05-25 15:32:47 +02:00
logs	Fix Windows linter errors	2026-06-16 16:21:13 +02:00
snake	Enable intrange linter, and fix warnings	2025-06-30 18:30:11 +02:00
tasks	Handle a command task's end-of-input on the UI thread	2026-07-17 12:35:54 +02:00
theme	Copy gocui files into lazygit repo under pkg/gocui	2026-04-30 14:29:08 +02:00
updates	Change direct access to Common.UserConfig to a getter	2024-08-18 10:24:52 +02:00
utils	Rework the custom pager config (rename to diff renderer)	2026-07-31 08:42:51 +02:00