jesseduffield.lazygit/pkg/gui/controllers/helpers
Stefan Haller ff4ae4a544 Fix possible crash when deleting a branch while filtering is active
The code that tries to reselect the same branch again uses GetItems, which in
case of filtering is the filtered list. After replacing the branches slice with
a new one, the filtered list is no longer up to date, so we must reapply the
filter before working with it. It so happens that refreshView does that, so
simply call that before setting the selection again; I don't think the order
matters in this case. Otherwise we'd have to insert another call to
ReApplyFilter before the call to GetItems, which we can avoid this way.

Note that this doesn't actually make anything work better in the case of
deleting a branch, since we can't reselect the deleted branch anyway of course.
But it avoids a possible crash if the branch that was deleted was the last one
in the unfiltered list.
2025-02-07 09:34:25 +01:00
..
amend_helper.go Improve prompts when amending commits 2023-09-01 18:55:16 +02:00
app_status_helper.go Extract the inner part of WithWaitingStatus as a synchronous variant of it 2025-01-30 08:49:58 +01:00
bisect_helper.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
branches_helper.go Allow deleting a range selection of branches 2024-12-01 10:59:54 +01:00
cherry_pick_helper.go Add number of commits to cherry-pick confirmation prompt 2025-01-08 21:08:42 -08:00
commits_helper.go Implement reboot-resistant commit message persistence 2025-02-07 09:28:27 +01:00
commits_helper_test.go Remove hard line breaks when rewording commits 2024-03-09 10:00:44 +01:00
confirmation_helper.go Only avoid the blank line at end of view if view is not editable 2025-01-20 17:52:53 +01:00
credentials_helper.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
diff_helper.go Adjust line number for working copy when editing a line 2025-01-07 17:46:51 +01:00
files_helper.go Remove calls to Error() 2024-04-18 10:10:30 +02:00
fixup_helper.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
fixup_helper_test.go Also return hunks with only added lines from parseDiff 2024-06-01 08:31:18 +02:00
gpg_helper.go Change direct access to Common.UserConfig to a getter 2024-08-18 10:24:52 +02:00
helpers.go Add command to find base commit for creating a fixup 2024-01-10 09:11:40 +01:00
host_helper.go Change direct access to Common.UserConfig to a getter 2024-08-18 10:24:52 +02:00
inline_status_helper.go Remove return value of HandleRender 2024-09-06 08:45:48 +02:00
merge_and_rebase_helper.go Show confirmation menu when trying to amend changes while there are conflicts 2025-01-30 08:53:34 +01:00
merge_conflicts_helper.go Remove return value of IContextMgr.Push/Pop et. al. 2024-09-06 08:45:48 +02:00
mode_helper.go Return error from RefreshOptions.Then 2024-04-18 10:10:30 +02:00
patch_building_helper.go Handle wrapped lines in patch explorer state 2024-12-23 12:24:09 +01:00
record_directory_helper.go split context common from helper common 2023-04-30 13:19:53 +10:00
refresh_helper.go Fix possible crash when deleting a branch while filtering is active 2025-02-07 09:34:25 +01:00
refs_helper.go Fix typos 2025-01-03 10:50:36 +11:00
repos_helper.go Remove ErrorMsg 2024-04-18 10:10:30 +02:00
search_helper.go Get rid of error return value of PostRefreshUpdate and a few related ones 2024-10-13 16:55:54 +02:00
snake_helper.go Bump gocui and adapt lazygit code 2024-12-01 10:40:08 +01:00
staging_helper.go Handle wrapped lines in patch explorer state 2024-12-23 12:24:09 +01:00
sub_commits_helper.go Get rid of error return value of PostRefreshUpdate and a few related ones 2024-10-13 16:55:54 +02:00
suggestions_helper.go pkg/gui: Allow user to select remote and branch when creating a PR 2024-11-23 11:52:21 +11:00
tags_helper.go Remove return value of OpenCommitMessagePanel 2024-09-06 08:45:48 +02:00
update_helper.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
upstream_helper.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
upstream_helper_test.go Standardise on using lo for slice functions 2023-07-30 18:51:23 +10:00
view_helper.go standardise helper args 2023-04-30 13:19:53 +10:00
window_arrangement_helper.go Standardise on 'screen mode' name 2025-01-11 14:25:48 +11:00
window_arrangement_helper_test.go Fix typos 2025-01-03 10:50:36 +11:00
window_helper.go Replace CurrentContext() with Context().Current() 2024-08-17 11:14:51 +02:00
working_tree_helper.go Implement reboot-resistant commit message persistence 2025-02-07 09:28:27 +01:00
worktree_helper.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00