mirror of
https://github.com/jesseduffield/lazygit.git
synced 2026-09-10 07:36:27 -04:00
23bcc19180
Up till now our approach to rendering things like file diffs, branch logs, and commit patches, has been to run a command on the command line, wait for it to complete, take its output as a string, and then write that string to the main view (or secondary view e.g. when showing both staged and unstaged changes of a file). This has caused various issues. For once, if you are flicking through a list of files and an untracked file is particularly large, not only will this require lazygit to load that whole file into memory (or more accurately it's equally large diff), it also will slow down the UI thread while loading that file, and if the user continued down the list, the original command might eventually resolve and replace whatever the diff is for the newly selected file. Following what we've done in lazydocker, I've added a tasks package for when you need something done but you want it to cancel as soon as something newer comes up. Given this typically involves running a command to display to a view, I've added a viewBufferManagerMap struct to the Gui struct which allows you to define these tasks on a per-view basis. viewBufferManagers can run files and directly write the output to their view, meaning we no longer need to use so much memory. In the tasks package there is a helper method called NewCmdTask which takes a command, an initial amount of lines to read, and then runs that command, reads that number of lines, and allows for a readLines channel to tell it to read more lines. We read more lines when we scroll or resize the window. There is an adapter for the tasks package in a file called tasks_adapter which wraps the functions from the tasks package in gui-specific stuff like clearing the main view before starting the next task that wants to write to the main view. I've removed some small features as part of this work, namely the little headers that were at the top of the main view for some situations. For example, we no longer show the upstream of a selected branch. I want to re-introduce this in the future, but I didn't want to make this tasks system too complicated, and in order to facilitate a header section in the main view we'd need to have a task that gets the upstream for the current branch, writes it to the header, then tells another task to write the branch log to the main view, but without clearing inbetween. So it would get messy. I'm thinking instead of having a separate 'header' view atop the main view to render that kind of thing (which can happen in another PR) I've also simplified the 'git show' to just call 'git show' and not do anything fancy when it comes to merge commits. I considered using this tasks approach whenever we write to a view. The only thing is that the renderString method currently resets the origin of a view and I don't want to lose that. So I've left some in there that I consider harmless, but we should probably be just using tasks now for all rendering, even if it's just strings we can instantly make. |
||
|---|---|---|
| .. | ||
| testdata | ||
| branch.go | ||
| branch_list_builder.go | ||
| commit.go | ||
| commit_file.go | ||
| commit_list_builder.go | ||
| commit_list_builder_test.go | ||
| dummies.go | ||
| errors.go | ||
| exec_live_default.go | ||
| exec_live_win.go | ||
| file.go | ||
| git.go | ||
| git_structs.go | ||
| git_test.go | ||
| loading_remotes.go | ||
| loading_tags.go | ||
| os.go | ||
| os_default_platform.go | ||
| os_test.go | ||
| os_windows.go | ||
| patch_manager.go | ||
| patch_modifier.go | ||
| patch_modifier_test.go | ||
| patch_parser.go | ||
| patch_rebases.go | ||
| pull_request.go | ||
| pull_request_test.go | ||
| remote.go | ||
| remote_branch.go | ||
| stash_entry.go | ||
| tag.go | ||