Stefan Haller cf8e5fd27e Recover diff-line identity by parsing the buffer, behind a swappable seam ... The focused main view's click/enter/e/G handlers all need the same thing: given a rendered diff row, the patch-space line it corresponds to. Until now that came solely from delta's lazygit-edit:// hyperlinks, which only carry a path and a single line number — no side. That's lossy: for a deletion the number is the old line, but the consumers fed it into new-file lookups, and two consecutive deletions (which share a new-file line number) couldn't be told apart at all. Replace GetFileAndLineForClickedDiffLine with GetDiffLineInfo, returning the fuller (file, type, new-line, old-line) record from diff-line-metadata-notes.md. This is mechanism #1: parse the decolorized view buffer — walk up to the file's "diff --git" section, reuse patch.Parse on it (splitting multi-file commit diffs on the "diff --git" boundaries), and read the type and line numbers off the patch arithmetic. It serves the structure-preserving renderings — no pager, git diff --color, and delta --color-only without line numbers — with no external dependency. To avoid trusting a mis-parse, the parser bails when a hunk's body no longer matches its header (Patch.IsWellFormed). That's what happens when a pager keeps the diff/hunk headers but restructures the body: delta's line-number gutters push the +/- marker off the start of each line, so every body line reads as context. Such renderings fall through to the next backend rather than yielding a confident wrong answer. (diff-so-fancy goes further and rewrites the headers too, so it fails even earlier, on the missing "diff --git".) GetDiffLineInfo is a seam with swappable backends: the buffer parser first, then the old hyperlink reader as a fallback for renderings the parser can't handle (delta's default mode, or delta with line-number gutters). The future #2 OSC per-cell metadata reader plugs in ahead of both, behind the same record shape. Wire the consumers to the record per that doc's field mapping: - dive into staging/patch building lands on the exact patch line, looking a deletion up by its old-file line number (PatchLineForOldLineNumber) so the two-deletions case resolves correctly; - `e` edits at the new-file line; - `G` anchors the PR link on the left (old) side for a deletion, the right (new) side otherwise. The hyperlink fallback can't convey the side, so it reports DiffLineOther, which the consumers treat as a non-deletion — i.e. exactly today's behavior. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>		2026-08-08 12:58:59 +02:00
..
format.go	Export PatchLine.isChange	2025-07-04 10:14:35 +02:00
hunk.go	Recover diff-line identity by parsing the buffer, behind a swappable seam	2026-08-08 12:58:59 +02:00
parse.go	Recover diff-line identity by parsing the buffer, behind a swappable seam	2026-08-08 12:58:59 +02:00
patch.go	Recover diff-line identity by parsing the buffer, behind a swappable seam	2026-08-08 12:58:59 +02:00
patch_builder.go	Guard the patch builder against concurrent access	2026-07-17 12:35:54 +02:00
patch_line.go	Fix selection after staging an added line	2026-03-19 16:57:53 +01:00
patch_test.go	Recover diff-line identity by parsing the buffer, behind a swappable seam	2026-08-08 12:58:59 +02:00
transform.go	Show renamed files in the custom patch builder	2026-07-04 13:05:09 +02:00