jesseduffield.lazygit/pkg/gui
Stefan Haller 57991c1da8 Fix crash when clicking in the status view
The click handler of MainViewController was registered as a global handler, so
it was used when a side panel was focused that doesn't have a
SwitchToFocusedMainViewController attached (e.g. Status, Worktrees, or
Submodules). This handler would then push the main view context, but with the
code that is meant only for toggling between the main view pair contexts, i.e.
with taking over the parentContext from the otherContext, which doesn't have one
at that point. This would later lead to a crash in onClick because the
parentContext was nil.

Fix this by splitting the click handler in two, one for when it already has the
focus, and one for toggling from the other view, and make these focus specific.
2025-05-22 14:38:40 +02:00
..
context Make '>' first jump to the beginning of the branch, and only then to the first commit 2025-05-11 13:55:43 +02:00
controllers Fix crash when clicking in the status view 2025-05-22 14:38:40 +02:00
filetree Fix discarding submodule changes in nested folders 2025-04-07 09:42:19 +02:00
keybindings Move labelByKey to config package 2025-02-21 13:20:33 +01:00
mergeconflicts Remove utils.Clamp, use lo.Clamp instead 2025-04-21 18:03:18 +02:00
modes Make Commit.Hash a getter for an unexported hash field 2025-04-29 14:57:15 +02:00
patch_exploring Fix crash when dragging from below the end of the diff upwards and then staging the range 2025-04-11 10:14:46 +02:00
popup Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
presentation Move Loader to presentation package 2025-05-06 09:52:53 +02:00
services/custom_commands Move NewDummyCommon to pkg/common 2025-05-06 09:43:26 +02:00
status Move Loader to presentation package 2025-05-06 09:52:53 +02:00
style Add function to render a hyperlink 2024-08-24 10:36:01 +02:00
types Make '>' first jump to the beginning of the branch, and only then to the first commit 2025-05-11 13:55:43 +02:00
background.go Add config for auto-forwarding branches after fetching 2025-04-21 18:06:09 +02:00
command_log_panel.go fix wording of random tip 2025-04-29 14:13:55 +02:00
context.go Cleanup: get rid of the variadic parameter of ContextMgr.Push 2025-04-08 16:08:25 +02:00
context_config.go move some methods 2023-04-30 13:19:53 +10:00
controllers.go Add new command "Move commits to new branch" 2025-04-21 18:12:50 +02:00
dummies.go Move NewDummyCommon to pkg/common 2025-05-06 09:43:26 +02:00
editors.go Show "hooks disabled" in title bar of commit message editor 2025-04-10 08:57:32 +02:00
extras_panel.go Add pageUp/pageDown/top/bottom keybindings to focused command log panel 2025-04-08 16:11:15 +02:00
global_handlers.go Make home and end keys work in prompts 2025-05-22 08:48:38 +02:00
gui.go Remove ICmdObj interface 2025-05-01 15:21:37 +02:00
gui_common.go Remove ICmdObj interface 2025-05-01 15:21:37 +02:00
gui_driver.go Fix clicking multiple times in an integration test 2024-10-18 10:06:52 +02:00
information_panel.go Bump gocui and adapt lazygit code 2024-12-01 10:40:08 +01:00
keybindings.go Add pageUp/pageDown/top/bottom keybindings to focused command log panel 2025-04-08 16:11:15 +02:00
layout.go Add IGuiCommon.GetViewBufferManagerForView 2025-04-21 18:03:18 +02:00
main_panels.go Fix race with PTYs in integration tests 2025-03-28 11:16:04 +01:00
menu_panel.go Cleanup: get rid of the variadic parameter of ContextMgr.Push 2025-04-08 16:08:25 +02:00
options_map.go Make WorkingTreeState a struct, and add cherry-picking and reverting states 2025-04-20 15:53:17 +02:00
pty.go Fix race with PTYs in integration tests 2025-03-28 11:16:04 +01:00
pty_windows.go Format code to pass lint 2021-09-16 21:38:43 +08:00
recent_repos_panel.go Remove unused field gui.IsNewRepo 2024-12-01 10:44:26 +01:00
tasks_adapter.go Change NewRenderStringWith{out}ScrollTask to reuse the task key of the existing task 2024-10-18 22:46:47 +02:00
test_mode.go Don't wait in integration tests when running in headless mode 2024-06-05 14:44:02 +02:00
view_helpers.go Render the main view only for the side context that it belongs to 2025-05-22 08:15:25 +02:00
views.go Enable AutoRenderHyperLinks for the tooltip view 2025-04-08 16:05:34 +02:00