jesseduffield.lazygit/pkg/gui
Stefan Haller 59303981f9 Simplify startBackgroundFetch
This code had a lot of logic that (fortunately) didn't work because it was
buggy:

- it was supposed to wait for the auto-fetch delay before fetching for the first
  time in case we start with a repo that we had open in a previous session (i.e.
  that appears in the recent repos list). This code actually ran always, not
  just for known repos, because the IsNewRepo flag is only set later, after this
  function runs. Fortunately, the code didn't work, because time.After starts a
  timer but doesn't wait for it (to do that, it would have to be
  `<-time.After`).
- if the first fetch fails with error 128, it was supposed to show an error
  message and not start the background fetch loop. Fortunately, this didn't work
  because 1) it was guarded by isNew which is always false here, and 2) because
  git's error message in this case is actually "exit code: 128", not "exit
  status 128" (maybe this has changed in git at some point).

I find both of these undesirable. Whenever I open a repo I want an auto-fetch to
be triggered immediately to get my branch information up to date as quickly as
possible. And if the initial fetch fails (e.g. because one of my remotes is
offline or doesn't exist any more), then that's no reason not to start the
auto-fetch loop anyway.

So let's simplify the code to do what it did before, but with much fewer lines
of code.
2024-12-01 10:44:26 +01:00
..
context Bump gocui and adapt lazygit code 2024-12-01 10:40:08 +01:00
controllers Bump gocui and adapt lazygit code 2024-12-01 10:40:08 +01:00
filetree Add new filter to only show tracked files in Files panel 2024-11-12 16:54:24 +11:00
keybindings Add range selection ability on list contexts 2024-01-19 10:47:21 +11:00
mergeconflicts Remove redundant variable dedeclarations 2024-05-19 16:38:21 +10:00
modes Allow pasting commits more than once 2024-10-13 16:55:54 +02:00
patch_exploring Bump gocui and adapt lazygit code 2024-12-01 10:40:08 +01:00
popup Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
presentation Add test to ensure that file icons are one rune 2024-10-13 16:51:27 +02:00
services/custom_commands Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
status Clean up error handling of WithWaitingStatus and WithWaitingStatusSync 2024-04-18 10:10:30 +02:00
style Add function to render a hyperlink 2024-08-24 10:36:01 +02:00
types Cleanup: remove isFocused parameter from GetContentToRender and related methods 2024-10-18 22:46:48 +02:00
background.go Simplify startBackgroundFetch 2024-12-01 10:44:26 +01:00
command_log_panel.go Change direct access to Common.UserConfig to a getter 2024-08-18 10:24:52 +02:00
context.go Remove return value of IContextMgr.Push/Pop et. al. 2024-09-06 08:45:48 +02:00
context_config.go move some methods 2023-04-30 13:19:53 +10:00
controllers.go Better local branch delete confirmation 2024-09-28 11:19:32 +02:00
dummies.go Optimize number of early calls to GetRepoPaths 2024-07-06 12:09:48 -07:00
editors.go Add emacs-keybinds for word navigation 2023-08-15 12:22:17 +02:00
extras_panel.go Remove return value of IContextMgr.Push/Pop et. al. 2024-09-06 08:45:48 +02:00
global_handlers.go Use our new hyperlink support in confirmations 2024-08-24 10:36:01 +02:00
gui.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
gui_common.go Get rid of error return value of PostRefreshUpdate and a few related ones 2024-10-13 16:55:54 +02:00
gui_driver.go Fix clicking multiple times in an integration test 2024-10-18 10:06:52 +02:00
information_panel.go Bump gocui and adapt lazygit code 2024-12-01 10:40:08 +01:00
keybindings.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
layout.go Bump gocui and adapt lazygit code 2024-12-01 10:40:08 +01:00
main_panels.go Remove return value of RenderToMainViews and some related functions 2024-09-06 08:45:48 +02:00
menu_panel.go Get rid of error return value of PostRefreshUpdate and a few related ones 2024-10-13 16:55:54 +02:00
options_map.go Bump gocui and adapt lazygit code 2024-12-01 10:40:08 +01:00
pty.go Bump gocui and adapt lazygit code 2024-12-01 10:40:08 +01:00
pty_windows.go Format code to pass lint 2021-09-16 21:38:43 +08:00
recent_repos_panel.go Optimize number of early calls to GetRepoPaths 2024-07-06 12:09:48 -07:00
tasks_adapter.go Change NewRenderStringWith{out}ScrollTask to reuse the task key of the existing task 2024-10-18 22:46:47 +02:00
test_mode.go Don't wait in integration tests when running in headless mode 2024-06-05 14:44:02 +02:00
view_helpers.go Bump gocui and adapt lazygit code 2024-12-01 10:40:08 +01:00
views.go Use AutoRenderHyperLinks in confirmation view 2024-09-28 12:04:51 +02:00