jesseduffield.lazygit/pkg/gui
Stefan Haller 8f3e59b78e Don't render staging view when it loses focus
As far as I understand, this was needed back when the staging context was still
responsible for rendering its highlight (as opposed to the gocui view, as it is
today). It was necessary to call it with isFocused=false so that it removed the
highlight. The isFocused bool is no longer used today (and we'll remove it in
the next commit), so there's no need to render the view here any more.

This fixes flickering when leaving the staging view by pressing escape. The
reason is that in this case the patch state was already set to nil by the time
we get here, so we would render an empty view for a brief moment.

On top of that, it fixes unwanted scrolling to the top when leaving the staging
view. The reason for this is that we have code in layout that scrolls views up
if needed, e.g. because the window got taller or the view content got shorter
(added in #3839). This kicked in because we emptied the view, and scrolled it
all the way to the top, which we don't want.
2024-10-18 22:46:47 +02:00
..
context Fix crash when viewing the divergence of a branch which is up to date with its upstream 2024-09-18 09:24:10 +02:00
controllers Don't render staging view when it loses focus 2024-10-18 22:46:47 +02:00
filetree Use map to quickly find children in BuildTreeFromFiles 2024-09-18 09:16:58 +02:00
keybindings Add range selection ability on list contexts 2024-01-19 10:47:21 +11:00
mergeconflicts Remove redundant variable dedeclarations 2024-05-19 16:38:21 +10:00
modes Allow pasting commits more than once 2024-10-13 16:55:54 +02:00
patch_exploring Fix pressing shift-down after clicking in diff view 2024-10-18 10:08:27 +02:00
popup Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
presentation Add test to ensure that file icons are one rune 2024-10-13 16:51:27 +02:00
services/custom_commands Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
status Clean up error handling of WithWaitingStatus and WithWaitingStatusSync 2024-04-18 10:10:30 +02:00
style Add function to render a hyperlink 2024-08-24 10:36:01 +02:00
types Get rid of error return value of PostRefreshUpdate and a few related ones 2024-10-13 16:55:54 +02:00
background.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
command_log_panel.go Change direct access to Common.UserConfig to a getter 2024-08-18 10:24:52 +02:00
context.go Remove return value of IContextMgr.Push/Pop et. al. 2024-09-06 08:45:48 +02:00
context_config.go move some methods 2023-04-30 13:19:53 +10:00
controllers.go Better local branch delete confirmation 2024-09-28 11:19:32 +02:00
dummies.go Optimize number of early calls to GetRepoPaths 2024-07-06 12:09:48 -07:00
editors.go Add emacs-keybinds for word navigation 2023-08-15 12:22:17 +02:00
extras_panel.go Remove return value of IContextMgr.Push/Pop et. al. 2024-09-06 08:45:48 +02:00
global_handlers.go Use our new hyperlink support in confirmations 2024-08-24 10:36:01 +02:00
gui.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
gui_common.go Get rid of error return value of PostRefreshUpdate and a few related ones 2024-10-13 16:55:54 +02:00
gui_driver.go Fix clicking multiple times in an integration test 2024-10-18 10:06:52 +02:00
information_panel.go Use our new hyperlink support in the information view 2024-08-24 10:36:01 +02:00
keybindings.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
layout.go Remove return value of IContextMgr.Push/Pop et. al. 2024-09-06 08:45:48 +02:00
main_panels.go Remove return value of RenderToMainViews and some related functions 2024-09-06 08:45:48 +02:00
menu_panel.go Get rid of error return value of PostRefreshUpdate and a few related ones 2024-10-13 16:55:54 +02:00
options_map.go Replace CurrentContext() with Context().Current() 2024-08-17 11:14:51 +02:00
pty.go Fix possible off-by-one error wrt PTY size 2024-06-23 12:36:40 +02:00
pty_windows.go Format code to pass lint 2021-09-16 21:38:43 +08:00
recent_repos_panel.go Optimize number of early calls to GetRepoPaths 2024-07-06 12:09:48 -07:00
tasks_adapter.go Change NewRenderStringWith{out}ScrollTask to reuse the task key of the existing task 2024-10-18 22:46:47 +02:00
test_mode.go Don't wait in integration tests when running in headless mode 2024-06-05 14:44:02 +02:00
view_helpers.go Get rid of error return value of PostRefreshUpdate and a few related ones 2024-10-13 16:55:54 +02:00
views.go Use AutoRenderHyperLinks in confirmation view 2024-09-28 12:04:51 +02:00