jesseduffield.lazygit/pkg/gui/controllers/helpers
Stefan Haller b35f8776e1 Warn when there are hunks with only added lines
The algorithm works by blaming the deleted lines, so if a hunk contains only
added lines, we can only hope that it also belongs in the same commit. Warn the
user about this.

Note: the warning might be overly agressive, we'll have to see if this is
annoying. The reason is that it depends on the diff context size whether added
lines go into their own hunk or are grouped together with other added or deleted
lines into one hunk. However, our algorithm uses a diff context size of 0,
because that makes it easiest to parse the diff; this results in hunks having
only added lines more often than what the user sees. For example, moving a line
of code down by two lines will likely result in a single hunk for the user, but
in two hunks for our algorithm. On the other hand, being this strict makes the
warning consistent. We could consider using the user's diff context size in the
algorithm, but then it would depend on the current context size whether the
warning appears, which could be confusing. Plus, it would make the algorithm
quite a bit more complicated.
2024-01-10 09:11:40 +01:00
..
amend_helper.go Improve prompts when amending commits 2023-09-01 18:55:16 +02:00
app_status_helper.go Add WithWaitingStatusSync 2023-12-09 15:28:40 +01:00
bisect_helper.go split context common from helper common 2023-04-30 13:19:53 +10:00
branches_helper.go Allow deleting remote tags/branches from local tag/branch views (#2738) 2023-08-10 17:39:26 +10:00
cherry_pick_helper.go Allow cherry-picking commits during a rebase 2023-09-18 10:50:19 +02:00
commits_helper.go Preserve the commit message correctly even if the description has blank lines 2024-01-09 14:31:53 +01:00
confirmation_helper.go Remove unused WithLoaderPanel code 2023-09-20 13:30:49 +02:00
credentials_helper.go Handle pending actions properly in git commands that require credentials 2023-07-08 22:54:52 +10:00
diff_helper.go Move IgnoreWhitespaceInDiffView to AppState, and persist it when it changes 2023-07-31 11:41:55 +02:00
files_helper.go use 'suspend' instead of 'editInTerminal' internally 2023-08-09 22:03:58 +10:00
fixup_helper.go Warn when there are hunks with only added lines 2024-01-10 09:11:40 +01:00
gpg_helper.go Use an interface for tasks instead of a concrete struct 2023-07-10 17:12:21 +10:00
helpers.go Add command to find base commit for creating a fixup 2024-01-10 09:11:40 +01:00
host_helper.go standardise helper args 2023-04-30 13:19:53 +10:00
inline_status_helper.go Fall back to WithWaitingStatus if item is scrolled out of view 2023-12-10 16:03:25 +01:00
merge_and_rebase_helper.go Use DisabledReason for rebasing a branch onto itself 2023-09-18 10:20:23 +02:00
merge_conflicts_helper.go Fix race condition 2023-05-16 21:01:38 +10:00
mode_helper.go Add WithWaitingStatusSync 2023-12-09 15:28:40 +01:00
patch_building_helper.go Don't pass ignoreWhitespace to git commands 2023-09-04 17:50:49 +02:00
record_directory_helper.go split context common from helper common 2023-04-30 13:19:53 +10:00
refresh_helper.go Add a sort order menu for local branches 2023-12-27 15:25:29 +01:00
refs_helper.go Add a sort order menu for local branches 2023-12-27 15:25:29 +01:00
repos_helper.go Remove sync mutex 2023-10-08 18:45:36 +02:00
search_helper.go When refreshing models, re-apply active filter for the corresponding view 2023-10-10 08:37:30 +02:00
snake_helper.go split context common from helper common 2023-04-30 13:19:53 +10:00
staging_helper.go Don't pass ignoreWhitespace to git commands 2023-09-04 17:50:49 +02:00
sub_commits_helper.go feat: add jump-to-panel label setting 2023-09-09 09:45:08 +02:00
suggestions_helper.go Standardise on using lo for slice functions 2023-07-30 18:51:23 +10:00
tags_helper.go Allow force-tagging if tag exists 2023-07-31 11:38:52 +02:00
update_helper.go Use an interface for tasks instead of a concrete struct 2023-07-10 17:12:21 +10:00
upstream_helper.go standardise helper args 2023-04-30 13:19:53 +10:00
upstream_helper_test.go Standardise on using lo for slice functions 2023-07-30 18:51:23 +10:00
view_helper.go standardise helper args 2023-04-30 13:19:53 +10:00
window_arrangement_helper.go Add config setting for side panel location (left or top) in half screen mode 2024-01-09 15:45:26 +01:00
window_arrangement_helper_test.go Add config setting for side panel location (left or top) in half screen mode 2024-01-09 15:45:26 +01:00
window_helper.go Return only visible views from TopViewInWindow 2023-12-10 15:57:51 +01:00
working_tree_helper.go Extract a WithEnsureCommitableFiles function 2023-08-29 09:10:59 +02:00
worktree_helper.go Use fields rather than methods on worktrees 2023-07-30 18:35:24 +10:00