mirror of
https://github.com/jesseduffield/lazygit.git
synced 2026-09-15 01:56:24 -04:00
14d717d77f
tcell's filterEvents goroutine sends events into eventQ with a plain
blocking send, while Fini (via finish/finalize) closes eventQ after
closing the quit channel. The goroutine can have already committed to
the ev = <-inQ select arm when quit is closed, so its send into eventQ
races with the close; the race detector flags this (send and close on
the same channel are unsynchronized), and if the close wins, the send
panics with "send on closed channel".
This was caught by the integration tests under the race detector,
where every test drives a real tScreen over a MockTerm and tears it
down via Fini, but it equally affects real-terminal shutdown.
Upstream fixed it in 243630d2 ("Fix screen Init/Fini races") by
tracking the filter goroutine in a WaitGroup that finalize waits for
before closing eventQ, and guarding the send with a select on quit.
That commit is not in a tagged release yet (latest is v3.4.0), so pin
the pseudo-version; the delta over v3.4.0 is just this fix, a Windows
key-release fix, a cell-rendering perf tweak, and dependency bumps.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| adrg/xdg | ||
| atotto/clipboard | ||
| aybabtme/humanlog | ||
| bahlo/generic-list-go | ||
| buger/jsonparser | ||
| cli | ||
| clipperhouse | ||
| cloudfoundry/jibber_jabber | ||
| creack/pty | ||
| davecgh/go-spew | ||
| fatih/color | ||
| gdamore | ||
| go-errors/errors | ||
| go-logfmt/logfmt | ||
| google/go-cmp | ||
| gookit/color | ||
| integrii/flaggy | ||
| jesseduffield | ||
| kardianos/osext | ||
| karimkhaleel/jsonschema | ||
| kr/logfmt | ||
| kyokomi/emoji/v2 | ||
| lucasb-eyer/go-colorful | ||
| mailru/easyjson | ||
| mattn | ||
| mgutz/str | ||
| mitchellh/go-ps | ||
| petermattis/goid | ||
| pmezard/go-difflib | ||
| rivo/uniseg | ||
| sahilm/fuzzy | ||
| samber/lo | ||
| sanity-io/litter | ||
| sasha-s/go-deadlock | ||
| sirupsen/logrus | ||
| spf13/afero | ||
| spkg/bom | ||
| stefanhaller/git-todo-parser | ||
| stretchr/testify | ||
| wk8/go-ordered-map/v2 | ||
| xo/terminfo | ||