mirror of
https://github.com/jesseduffield/lazygit.git
synced 2026-09-11 08:06:25 -04:00
a61be44e92
runAndStreamAux reads the stdout buffer (and, when output is suppressed, the combinedOutput buffer) for its error message after handler.wait() returns, but the goroutine that fills those buffers by draining the command's output isn't awaited, so the reads raced its final writes. Own the goroutine here rather than letting the onRun callbacks spawn it, and join it before reading the buffers. The pty reader reaches EOF on its own once the process exits, but the non-pty pipe never does, so its handler now closes the read end to unblock the reader; the pipe is synchronous, so by the time the command has exited all of its output has already been read and nothing is lost. This also plugs the goroutine that the non-pty streaming path previously leaked on every command. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| cmd_obj.go | ||
| cmd_obj_builder.go | ||
| cmd_obj_runner.go | ||
| cmd_obj_runner_test.go | ||
| cmd_obj_test.go | ||
| copy.go | ||
| dummies.go | ||
| fake_cmd_obj_runner.go | ||
| gui_io.go | ||
| new_shell_windows_test.go | ||
| os.go | ||
| os_default_platform.go | ||
| os_default_test.go | ||
| os_test.go | ||
| os_windows.go | ||
| os_windows_test.go | ||
| pty.go | ||
| pty_unix.go | ||
| pty_windows.go | ||