mirror of
https://github.com/jesseduffield/lazygit.git
synced 2026-09-11 16:16:28 -04:00
d251faddec
The pty teardown in Close runs on a background goroutine that doesn't get to finish when lazygit is quitting: the process exits milliseconds after the view buffer managers are closed. The job objects still cover the clients -- KILL_ON_JOB_CLOSE reaps them when the process's handles are rundown at exit -- but nothing reaps the conhost, so on Windows builds whose conhost fails to run down on its own, quitting leaks one conhost per live pty. This is not a rare timing window: a diff longer than what has been read keeps its git process (and thus its pty and conhost) running for the entire time it is displayed, so that scrolling can read more. Quitting while looking at a long diff is therefore the common case, and with an external differ configured it leaks a conhost on affected builds on almost every quit. Fix this by having the gui's shutdown path wait synchronously for the in-flight teardowns after closing the view buffer managers. A quit signal makes the teardowns skip the conhost rundown wait -- the conhost serves nothing once its clients are dead, and the exit must not stall for its sake -- so the wait normally completes in milliseconds, keeping quit as fast as before; a 2-second cap protects the exit path even if a teardown wedges. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| cmd_obj.go | ||
| cmd_obj_builder.go | ||
| cmd_obj_runner.go | ||
| cmd_obj_runner_test.go | ||
| cmd_obj_test.go | ||
| copy.go | ||
| dummies.go | ||
| fake_cmd_obj_runner.go | ||
| gui_io.go | ||
| new_shell_windows_test.go | ||
| os.go | ||
| os_default_platform.go | ||
| os_default_test.go | ||
| os_test.go | ||
| os_windows.go | ||
| os_windows_test.go | ||
| pty.go | ||
| pty_unix.go | ||
| pty_windows.go | ||
| pty_windows_test.go | ||