From 63c0e77aaf18b72c839b1113c1e2f9514413643b Mon Sep 17 00:00:00 2001 From: Adrian Miranda Date: Sun, 24 May 2026 22:06:15 -0300 Subject: [PATCH] fix: handle browser paths safely (#234) --- git-open | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/git-open b/git-open index 8581e6c..a367db6 100755 --- a/git-open +++ b/git-open @@ -303,8 +303,21 @@ case $( uname -s ) in esac if (( print_only )); then - BROWSER="echo" + printf '%s\n' "$openurl" + exit 0 fi # open it in a browser -${BROWSER:-$open} "$openurl" +if [[ -n "$BROWSER" ]]; then + if [[ -x "$BROWSER" ]]; then + "$BROWSER" "$openurl" + exit $? + fi + + if command -v -- "$BROWSER" >/dev/null 2>&1; then + "$BROWSER" "$openurl" + exit $? + fi +fi + +"$open" "$openurl"