From 775361b509f3ea9aabb8b3a81162b2931283db40 Mon Sep 17 00:00:00 2001 From: August Valera <4U6U57@gmail.com> Date: Thu, 15 Feb 2018 22:23:37 -0800 Subject: [PATCH] Fix shellcheck --- git-open | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/git-open b/git-open index e009116..b55e93a 100755 --- a/git-open +++ b/git-open @@ -56,7 +56,7 @@ if [[ -z "$giturl" ]]; then exit 1 fi -ssh_config=${ssh_config:-~/.ssh/config} +ssh_config=${ssh_config:-"$HOME/.ssh/config"} # Resolves an ssh alias defined in ssh_config to it's corresponding hostname # echos out result, should be used within subshell $( ssh_resolve $host ) # echos out nothing if alias could not be resolved @@ -157,7 +157,7 @@ protocol=$(getConfig "protocol") branch=${2:-$(git symbolic-ref -q --short HEAD)} # Split arguments on '/' -IFS='/' pathargs=($urlpath) +IFS='/' read -r -a pathargs <<<"$urlpath" if (( is_issue )); then # For issues, take the numbers and preprend 'issues/' @@ -180,6 +180,7 @@ elif [[ "${#pathargs[@]}" -ge 3 && ${pathargs[${#pathargs[@]} - 3]} == 'scm' ]]; pathPref=("${pathargs[*]:0:${#pathargs[@]} - 3}") # Replace the 'scm' element, with 'projects'. Keep the first argument, the string 'repos', and finally the rest of the arguments. + # shellcheck disable=SC2206 pathargs=(${pathPref[@]} 'projects' ${pathargs[${#pathargs[@]} - 2]} 'repos' "${pathargs[@]:${#pathargs[@]} - 1}") IFS='/' urlpath="${pathargs[*]}" providerBranchRef="/browse?at=$branch"