From 4e127dcd39ba400f99bf45ff06b88ce41eb06ec7 Mon Sep 17 00:00:00 2001
From: romir kulshrestha <romir.kulshrestha@gmail.com>
Date: Fri, 9 Feb 2024 07:12:49 +0100
Subject: [PATCH] add comments

---
 bin/pyenv-sh-activate   | 14 ++++++++++----
 bin/pyenv-sh-deactivate |  2 ++
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/bin/pyenv-sh-activate b/bin/pyenv-sh-activate
index a28d26f..4a13ced 100755
--- a/bin/pyenv-sh-activate
+++ b/bin/pyenv-sh-activate
@@ -246,11 +246,17 @@ if [ -z "${PYENV_VIRTUALENV_DISABLE_PROMPT}" ]; then
   fish )
     if [ -z "${QUIET}" ]; then
       cat <<EOS
-      functions -e _pyenv_old_prompt
-      functions -c fish_prompt _pyenv_old_prompt
+      functions -e _pyenv_old_prompt              # remove old prompt function if exists. 
+                                                  # since everything is in memory, it's safe to
+                                                  # remove it.
+      functions -c fish_prompt _pyenv_old_prompt  # backup old prompt function
+
+      # from python-venv
       function fish_prompt
-          echo -n "(${venv}) "
-          _pyenv_old_prompt
+          set -l prompt (_pyenv_old_prompt)       # call old prompt function first since it might 
+                                                  # read exit status
+          echo -n "(${venv}) "                    # add virtualenv to prompt
+          string join -- \n \$prompt              # handle multiline prompts
       end
 EOS
     fi
diff --git a/bin/pyenv-sh-deactivate b/bin/pyenv-sh-deactivate
index 93a288f..ff37313 100755
--- a/bin/pyenv-sh-deactivate
+++ b/bin/pyenv-sh-deactivate
@@ -188,7 +188,9 @@ esac
 case "${shell}" in
 fish )
   cat <<EOS
+  # check if old prompt function exists
   if functions -q _pyenv_old_prompt
+    # remove old prompt function if exists.
     functions -e fish_prompt
     functions -c _pyenv_old_prompt fish_prompt
     functions -e _pyenv_old_prompt