From a33b30fa2db1211ccecd8e0079dd476692ce99d6 Mon Sep 17 00:00:00 2001 From: Tim Hawes Date: Sun, 2 Aug 2026 21:39:49 -0400 Subject: [PATCH] versions: fix --executables portability regression Replace the use of `xargs -r` and `basename -a` in the `--executables` fast path with Bash 3.2-compatible parameter expansion. The previous implementation relied on non-portable utility options, causing `pyenv rehash` and shell initialization to fail on illumos, OpenBSD, and other non-GNU userlands. Preserve the optimized executable discovery path by continuing to discover executables directly from the versions directory and deduplicate their basenames. --- libexec/pyenv-versions | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/libexec/pyenv-versions b/libexec/pyenv-versions index 91cb56d4..1466209c 100755 --- a/libexec/pyenv-versions +++ b/libexec/pyenv-versions @@ -42,9 +42,15 @@ versions_dir="${PYENV_ROOT}/versions" if [[ -n "$executables" ]]; then if [ -d "$versions_dir" ]; then shopt -s dotglob nullglob - # MacOS 12+ and FreeBSD 15 support `xargs -r -0' and `basename -a' - # `sort -u` is simpler and a bit faster than `awk '!seen[$0]++'`, with the same result for rehash purposes - printf '%s\0' "$versions_dir"/*/bin/* "$versions_dir"/*/envs/*/bin/* | xargs -0 -r basename -a | sort -u + # Fast path for rehash: skip filtering and link resolution. + # Discover executables directly from the versions directory and + # deduplicate their basenames. Use bash 3.2 conventions to keep code portable. + for path in \ + "$versions_dir"/*/bin/* \ + "$versions_dir"/*/envs/*/bin/* + do + printf '%s\n' "${path##*/}" + done | sort -u shopt -u dotglob nullglob fi exit 0