feat(git-release): push tags first to help ci tools not miss them

If you are buliding on CircleCI for example, pushing the commits first
can lead to a race where CI env will not see the tags since the pull
happened before the tags were finished pushing.

It should be fully safe (and backwards-compatible) to change the order
of pushing to the remote.
This commit is contained in:
Dominic Barnes 2018-01-23 13:51:41 -08:00
parent c2efbc889d
commit 5639160b8b

View file

@ -91,8 +91,8 @@ if test $# -gt 0; then
git commit -a -m "$msg"
# shellcheck disable=SC2086
git tag $version -a -m "$msg" \
&& git push $remote \
&& git push $remote --tags \
&& git push $remote \
&& hook post-release $hook_args \
&& echo "... complete"
else